Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect range on diagnostic on contracts with non-ascii characters #248

Closed
antico5 opened this issue Sep 7, 2022 · 0 comments · Fixed by #253
Closed

Incorrect range on diagnostic on contracts with non-ascii characters #248

antico5 opened this issue Sep 7, 2022 · 0 comments · Fixed by #253

Comments

@antico5
Copy link
Collaborator

antico5 commented Sep 7, 2022

Solc references offsets as byte count instead of unicode character count, but VSCode uses the latter. This results in the diagnostics being shown in incorrect ranges.
antico5 added a commit that referenced this issue Sep 8, 2022
@antico5
fix: diagnostics wrong position on unicode characters (#248)
8bf3dd6
@antico5 antico5 mentioned this issue Sep 8, 2022
Merged
antico5 added a commit that referenced this issue Sep 8, 2022
@antico5
fix: diagnostics wrong position on unicode characters (#248)
bf8ae16
antico5 added a commit that referenced this issue Sep 9, 2022
@antico5
fix: diagnostics wrong position on unicode characters (#248)
004d002
antico5 added a commit that referenced this issue Sep 9, 2022
@antico5
fix: diagnostics wrong position on unicode characters (#248)
525e527
antico5 added a commit that referenced this issue Sep 9, 2022
@antico5
fix: diagnostics wrong position on unicode characters (#248)
8d265e0
antico5 added a commit that referenced this issue Sep 14, 2022
@antico5
fix: diagnostics wrong position on unicode characters (#248)
cd0e1a0
antico5 added a commit that referenced this issue Sep 20, 2022
@antico5
fix: diagnostics wrong position on unicode characters (#248)
f1fa33a
antico5 added a commit that referenced this issue Sep 20, 2022
@antico5
fix: diagnostics wrong position on unicode characters (#248)
40967d0
@antico5 antico5 mentioned this issue Sep 20, 2022
Merged
antico5 added a commit that referenced this issue Sep 21, 2022
@antico5
fix: diagnostics wrong position on unicode characters (#248)
b1b9f88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: diagnostics wrong position on unicode characters (#248) NomicFoundation/hardhat-vscode
1 participant
@antico5