fix: diagnostics wrong position on unicode characters (#248) #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antico5
force-pushed
the
diagnostics-encoding-length-248
branch
from
8bf3dd6 to
bf8ae16
Compare
alcuadrado
reviewed
Sep 9, 2022
antico5
force-pushed
the
diagnostics-encoding-length-248
branch
3 times, most recently
from
525e527 to
8d265e0
Compare
kanej
reviewed
Sep 13, 2022
| continue; | ||
| } | ||
|
|
||
| const normalizeOffset = (text: string, offset: number) => { |
There was a problem hiding this comment.
Can we move this function out and declare it in the top level file?
antico5
force-pushed
the
diagnostics-encoding-length-248
branch
from
8d265e0 to
cd0e1a0
Compare
antico5
force-pushed
the
diagnostics-encoding-length-248
branch
from
cd0e1a0 to
f1fa33a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #248