Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use solidity analyzer #3052

Merged
merged 3 commits into from
Aug 28, 2022
Merged

Use solidity analyzer #3052

merged 3 commits into from
Aug 28, 2022

Conversation

alcuadrado
Copy link
Member

Fith PR of the compilation times optimization effort.

This PR stops using @fvictorio's parser in favor of my solidity-analyzer library 😜

I believe this should be ready to review.

Depends on #3051

@vercel
Copy link

vercel bot commented Aug 17, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
hardhat ✅ Ready (Inspect) Visit Preview Aug 28, 2022 at 2:47PM (UTC)
hardhat-storybook ✅ Ready (Inspect) Visit Preview Aug 28, 2022 at 2:47PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Aug 17, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 136fe08

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

This issue is also being tracked on Linear.

We use Linear to manage our development process, but we keep the conversations on Github.

LINEAR-ID: ea957f29-aec0-4cbc-92e5-bc9dce097acf

@alcuadrado alcuadrado mentioned this pull request Aug 17, 2022
Merged
@alcuadrado alcuadrado force-pushed the optimized-build-info-generation branch from cca4140 to 5a4835c Compare August 27, 2022 20:00
@alcuadrado alcuadrado force-pushed the use-solidity-analyzer branch from 06bd931 to e38ed40 Compare August 28, 2022 13:45
Base automatically changed from optimized-build-info-generation to compiler-optimizations August 28, 2022 21:56
@alcuadrado alcuadrado merged commit fd0a344 into compiler-optimizations Aug 28, 2022
@alcuadrado alcuadrado deleted the use-solidity-analyzer branch August 28, 2022 21:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fvictorio fvictorio fvictorio approved these changes

Assignees

@feuGeneA feuGeneA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alcuadrado @fvictorio @feuGeneA