-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc optimizations #3053
Misc optimizations #3053
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This issue is also being tracked on Linear. We use Linear to manage our development process, but we keep the conversations on Github. LINEAR-ID: c89d90fa-1b26-46d6-9b84-f77b0d70ea5e |
06bd931
to
e38ed40
Compare
4068b65
to
9411a01
Compare
packages/hardhat-core/sample-projects/javascript/contracts/Lock.sol
Outdated
Show resolved
Hide resolved
3874967
to
9229545
Compare
This is missing test. It should be part of @nomicfoundation/hardhat-common
1c49790
to
b47f7d8
Compare
3ba291c
to
6f04510
Compare
6f04510
to
270bd13
Compare
Finally ready! This should have been a few prs. Handling different filesystems at the same time is so painful! |
packages/hardhat-core/test/internal/core/config/config-loading.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment; pre-approving.
Co-authored-by: Franco Victorio <victorio.franco@gmail.com>
Sixth PR of the compilation times optimization effort.
This PR introduces multiple smaller optimizations:
glob
)loadash
whenever possible, and only load its necessary modules when we still use it.execFile
instead ofexec
to run the compiler, asexec
spawns a new shell (!!!!!!)hardhat/console.sol
in the sample project as it's slow to compile.WIP: Parts of this require tests.
Depends on #3052