Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidating terminology in the schema/codegen crates #373

Closed
OmarTawfik opened this issue Mar 20, 2023 · 0 comments · Fixed by #530
Closed

Consolidating terminology in the schema/codegen crates #373

OmarTawfik opened this issue Mar 20, 2023 · 0 comments · Fixed by #530
Assignees
@AntonyBlakey @OmarTawfik
Milestone
1️⃣ Alpha Preview

Comments

@OmarTawfik
Copy link
Collaborator

OmarTawfik commented Mar 20, 2023 •
edited
Loading

  1. Parser vs TriviaParser vs PrecedenceParser. Maybe RuleParser / TriviaParser / PrattParser (comment)?
  2. We renamed ebnf "expressions" to parser/scanner "definitions", but left a lot of expr, expression, and expressions variables and methods in the codebase (comment).
  3. PrecedenceParser uses "operators" for the top-level operators, and their inner operator definition, which is confusing. Maybe use "expressions" and "expression.operator" instead?
@OmarTawfik OmarTawfik added this to the 2️⃣ Beta Preview milestone Mar 20, 2023
@OmarTawfik OmarTawfik mentioned this issue Mar 20, 2023
Merged
@OmarTawfik OmarTawfik self-assigned this Jul 10, 2023
@OmarTawfik OmarTawfik mentioned this issue Jul 10, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 11, 2023
@OmarTawfik
consolidating terminology in codegen crates (#530)
7ebad9e 
Cleanup of pre-release changes, to make it easier for onboarding.

- Replace the older notation of EBNF "expressions" in codegen with the
newer/consistent parser/scanner terminology.
- Rename `PrecedenceParser::Operators` to
`PrecedenceParser::Expressions` for accuracy, as each contain their own
operator.

Closes #373
@OmarTawfik OmarTawfik added this to the 1️⃣ Alpha Preview milestone Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AntonyBlakey AntonyBlakey

@OmarTawfik OmarTawfik

Labels
None yet
Projects
No open projects
Slang - 2023 H1
Status: ✅ Done
Milestone
1️⃣ Alpha Preview
Development

Successfully merging a pull request may close this issue.

consolidating terminology in codegen crates OmarTawfik-forks/slang
2 participants
@AntonyBlakey @OmarTawfik