Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow precedence expressions to omit operator classes #332

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Allow precedence expressions to omit operator classes #332

merged 1 commit into from
Mar 1, 2023

Conversation

AntonyBlakey
Copy link
Contributor

No description provided.

@AntonyBlakey AntonyBlakey self-assigned this Feb 20, 2023
@AntonyBlakey AntonyBlakey added this to the 1️⃣ Alpha Preview milestone Feb 20, 2023
This was linked to issues Feb 20, 2023
expose operator semantics in grammar schema #310
Closed
Make precedence parsing a top-level construct #272
Closed
Base automatically changed from AntonyBlakey/allow-productions-to-be-introduced-after-first-version to AntonyBlakey/improve-error-messages-from-tries February 22, 2023 01:41
@AntonyBlakey AntonyBlakey force-pushed the AntonyBlakey/allow-precedence-expressions-to-omit-operator-classes branch from 7b84623 to 86d0880 Compare February 23, 2023 17:39
@AntonyBlakey AntonyBlakey force-pushed the AntonyBlakey/improve-error-messages-from-tries branch from da84cda to 93061e8 Compare February 24, 2023 23:01
@AntonyBlakey AntonyBlakey force-pushed the AntonyBlakey/allow-precedence-expressions-to-omit-operator-classes branch from 4afbc26 to 9776de1 Compare February 24, 2023 23:13
@AntonyBlakey AntonyBlakey force-pushed the AntonyBlakey/improve-error-messages-from-tries branch from 93061e8 to 715fda7 Compare February 25, 2023 00:59
@AntonyBlakey AntonyBlakey force-pushed the AntonyBlakey/allow-precedence-expressions-to-omit-operator-classes branch from 9776de1 to 402b858 Compare February 25, 2023 01:00
@AntonyBlakey AntonyBlakey force-pushed the AntonyBlakey/improve-error-messages-from-tries branch from 715fda7 to 7c9ea53 Compare February 25, 2023 01:06
@AntonyBlakey AntonyBlakey force-pushed the AntonyBlakey/allow-precedence-expressions-to-omit-operator-classes branch from 402b858 to 1fae00b Compare February 25, 2023 01:07
Base automatically changed from AntonyBlakey/improve-error-messages-from-tries to main February 25, 2023 01:12
@AntonyBlakey AntonyBlakey force-pushed the AntonyBlakey/allow-precedence-expressions-to-omit-operator-classes branch 3 times, most recently from f8d7d63 to b2c0a03 Compare February 25, 2023 11:04
@AntonyBlakey AntonyBlakey marked this pull request as ready for review February 26, 2023 02:00
@AntonyBlakey AntonyBlakey force-pushed the AntonyBlakey/allow-precedence-expressions-to-omit-operator-classes branch 2 times, most recently from 03dcd38 to c569aa1 Compare February 26, 2023 07:17
@AntonyBlakey AntonyBlakey linked an issue Feb 26, 2023 that may be closed by this pull request
ProductionKind should not include kinds from sub-expressions, to prevent parsing on their own #324
Closed
@AntonyBlakey AntonyBlakey force-pushed the AntonyBlakey/allow-precedence-expressions-to-omit-operator-classes branch from c569aa1 to 577d25f Compare February 27, 2023 04:44
@AntonyBlakey AntonyBlakey enabled auto-merge (squash) February 27, 2023 05:03
@OmarTawfik OmarTawfik self-requested a review February 27, 2023 23:32
@OmarTawfik OmarTawfik mentioned this pull request Feb 28, 2023
Closed
OmarTawfik
OmarTawfik reviewed Feb 28, 2023
View reviewed changes
Copy link
Collaborator

@OmarTawfik OmarTawfik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few questions/suggestions..

OmarTawfik
OmarTawfik approved these changes Mar 1, 2023
View reviewed changes
Copy link
Collaborator

@OmarTawfik OmarTawfik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking changes here. Left a few questions/suggestions.

@AntonyBlakey AntonyBlakey merged commit 34db076 into main Mar 1, 2023
@AntonyBlakey AntonyBlakey deleted the AntonyBlakey/allow-precedence-expressions-to-omit-operator-classes branch March 1, 2023 07:57
@OmarTawfik OmarTawfik mentioned this pull request Mar 7, 2023
Merged
This was referenced Mar 20, 2023
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OmarTawfik OmarTawfik OmarTawfik approved these changes

Assignees

@AntonyBlakey AntonyBlakey

Labels
None yet
Projects
None yet
Milestone
1️⃣ Alpha Preview
2 participants
@AntonyBlakey @OmarTawfik