Mirror rowan architecture in our CST #502

AntonyBlakey · 2023-06-15T15:57:28Z

No description provided.

changeset-bot · 2023-06-15T15:57:32Z

🦋 Changeset detected

Latest commit: 23c7641

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
changelog	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

crates/codegen/syntax_templates/src/rust/cst_visitor.rs

.changeset/shy-carrots-love.md

crates/codegen/syntax_templates/src/shared/cst.rs

crates/codegen/syntax_templates/src/shared/parse_error.rs

crates/codegen/syntax_templates/src/shared/parser_helpers.rs

crates/solidity/outputs/npm/package/src/generated/index.d.ts

crates/solidity/testing/utils/src/cst_snapshots/mod.rs

crates/solidity/testing/utils/src/cst_snapshots/test_nodes.rs

.changeset/shy-carrots-love.md

Cargo.lock

...idity/testing/snapshots/cst_output/ContractDefinition/zero_length_input/generated/0.4.11.yml

.../solidity/testing/snapshots/cst_output/Expression/function_call_options/generated/0.4.11.yml

crates/solidity/testing/snapshots/cst_output/MappingType/named_both/generated/0.4.11.yml

...dity/testing/snapshots/cst_output/NumericExpression/hex_uppercase_prefix/generated/0.5.0.yml

crates/solidity/testing/snapshots/cst_output/SourceUnit/partial_definition/generated/0.4.11.yml

...testing/snapshots/cst_output/HexStringLiteral/invalid_leading_separator/generated/0.4.11.yml

crates/codegen/syntax_templates/src/shared/parse_error.rs

OmarTawfik

Fantastic work!

I think there is a couple of test regressions that we might want to address before merging. And also some new APIs that I'm not sure if it was intentional to expose them, or if we should keep them private for now. Otherwise, looks great.

...dity/testing/snapshots/cst_output/Expression/function_call_options_split/generated/0.8.0.yml

@AntonyBlakey

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or [setup this action to publish automatically](https://github.com/changesets/action#with-publishing). If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @nomicfoundation/slang@0.7.0 ### Minor Changes - [#502](#502) [`c383238`](c383238) Thanks [@AntonyBlakey](https://github.com/AntonyBlakey)! - Added error recovery i.e. a CST is _always_ produced, even if there are errors. The erroneous/skipped text is in the CST as a `TokenKind::SKIPPED` token. - [#501](#501) [`cb221fe`](cb221fe) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - generate typescript string enums for CST kinds - [#517](#517) [`8bd5446`](8bd5446) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - extract inlined and sub-expressions in language grammar - [#518](#518) [`b3b562b`](b3b562b) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - fill in missing CST node names - [#515](#515) [`f24e873`](f24e873) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - switch over the NPM package to use CommonJS modules instead of ES modules. - [#498](#498) [`44f1ff7`](44f1ff7) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - flatten unnamed CST nodes into parent nodes - [#502](#502) [`c383238`](c383238) Thanks [@AntonyBlakey](https://github.com/AntonyBlakey)! - Use the Rowan model for the CST i.e. TokenNodes contain the string content, and RuleNodes contain only the combined _length_ of their children's text. - [#499](#499) [`1582d60`](1582d60) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - preserve correct ranges on empty rule nodes - [#500](#500) [`73ddac9`](73ddac9) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - inlining CST nodes that offer no additional syntactic information - [#512](#512) [`72dc3d3`](72dc3d3) Thanks [@AntonyBlakey](https://github.com/AntonyBlakey)! - Expression productions now correctly wrap the recursive 'calls' in a rule node ## changelog@0.7.0 ### Minor Changes - [#502](#502) [`c383238`](c383238) Thanks [@AntonyBlakey](https://github.com/AntonyBlakey)! - Added error recovery i.e. a CST is _always_ produced, even if there are errors. The erroneous/skipped text is in the CST as a `TokenKind::SKIPPED` token. - [#501](#501) [`cb221fe`](cb221fe) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - generate typescript string enums for CST kinds - [#517](#517) [`8bd5446`](8bd5446) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - extract inlined and sub-expressions in language grammar - [#518](#518) [`b3b562b`](b3b562b) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - fill in missing CST node names - [#515](#515) [`f24e873`](f24e873) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - switch over the NPM package to use CommonJS modules instead of ES modules. - [#498](#498) [`44f1ff7`](44f1ff7) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - flatten unnamed CST nodes into parent nodes - [#502](#502) [`c383238`](c383238) Thanks [@AntonyBlakey](https://github.com/AntonyBlakey)! - Use the Rowan model for the CST i.e. TokenNodes contain the string content, and RuleNodes contain only the combined _length_ of their children's text. - [#499](#499) [`1582d60`](1582d60) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - preserve correct ranges on empty rule nodes - [#500](#500) [`73ddac9`](73ddac9) Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - inlining CST nodes that offer no additional syntactic information - [#512](#512) [`72dc3d3`](72dc3d3) Thanks [@AntonyBlakey](https://github.com/AntonyBlakey)! - Expression productions now correctly wrap the recursive 'calls' in a rule node Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

AntonyBlakey force-pushed the AntonyBlakey/unwrap-types-in-Node-enum branch from a591545 to b2b59ce Compare June 18, 2023 05:39

AntonyBlakey force-pushed the AntonyBlakey/unwrap-types-in-Node-enum branch 6 times, most recently from ce8a246 to d811506 Compare June 28, 2023 01:11

OmarTawfik reviewed Jun 28, 2023

View reviewed changes

crates/codegen/syntax_templates/src/rust/cst_visitor.rs Outdated Show resolved Hide resolved

AntonyBlakey force-pushed the AntonyBlakey/unwrap-types-in-Node-enum branch 5 times, most recently from 8e7bd6a to 42a0020 Compare July 2, 2023 12:25

AntonyBlakey self-assigned this Jul 2, 2023

AntonyBlakey force-pushed the AntonyBlakey/unwrap-types-in-Node-enum branch 2 times, most recently from d494760 to b4862d6 Compare July 2, 2023 13:08

AntonyBlakey marked this pull request as ready for review July 2, 2023 13:19

AntonyBlakey requested a review from a team as a code owner July 2, 2023 13:19

AntonyBlakey force-pushed the AntonyBlakey/unwrap-types-in-Node-enum branch 2 times, most recently from f3f6518 to bff6e50 Compare July 3, 2023 10:01

AntonyBlakey mentioned this pull request Jul 3, 2023

Keep utf16 offsets for text positions #491

Closed

AntonyBlakey force-pushed the AntonyBlakey/unwrap-types-in-Node-enum branch 3 times, most recently from 9ae4d49 to 71650f4 Compare July 3, 2023 12:27

OmarTawfik reviewed Jul 3, 2023

View reviewed changes

.changeset/shy-carrots-love.md Outdated Show resolved Hide resolved

AntonyBlakey force-pushed the AntonyBlakey/unwrap-types-in-Node-enum branch from 71650f4 to aff581c Compare July 3, 2023 15:55