Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert NPM package to CommonJS #515

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Conversation

OmarTawfik
Copy link
Collaborator

switch over the NPM package to use CommonJS modules instead of ES modules, to allow to be used from CommonJS packages.

switch over the NPM package to use CommonJS modules instead of ES modules.
@changeset-bot
Copy link

changeset-bot bot commented Jul 6, 2023

🦋 Changeset detected

Latest commit: 6601061

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
changelog Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@OmarTawfik OmarTawfik marked this pull request as ready for review July 6, 2023 13:46
@OmarTawfik OmarTawfik requested a review from a team as a code owner July 6, 2023 13:46
Copy link
Contributor

@AntonyBlakey AntonyBlakey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to pick up TextIndex and TextRange in crates/solidity/outputs/npm/package/syntax/nodes/index.js when rebasing.

@OmarTawfik OmarTawfik added this pull request to the merge queue Jul 6, 2023
Merged via the queue into main with commit f24e873 Jul 6, 2023
@OmarTawfik OmarTawfik deleted the OmarTawfik/commonjs-npm-package branch July 6, 2023 15:56
@github-actions github-actions bot mentioned this pull request Jul 6, 2023
github-merge-queue bot pushed a commit that referenced this pull request Jul 7, 2023
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and publish to npm
yourself or [setup this action to publish
automatically](https://github.com/changesets/action#with-publishing). If
you're not ready to do a release yet, that's fine, whenever you add more
changesets to main, this PR will be updated.


# Releases
## @nomicfoundation/slang@0.7.0

### Minor Changes

- [#502](#502)
[`c383238`](c383238)
Thanks [@AntonyBlakey](https://github.com/AntonyBlakey)! - Added error
recovery i.e. a CST is _always_ produced, even if there are errors. The
erroneous/skipped text is in the CST as a `TokenKind::SKIPPED` token.

- [#501](#501)
[`cb221fe`](cb221fe)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - generate
typescript string enums for CST kinds

- [#517](#517)
[`8bd5446`](8bd5446)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - extract inlined
and sub-expressions in language grammar

- [#518](#518)
[`b3b562b`](b3b562b)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - fill in missing
CST node names

- [#515](#515)
[`f24e873`](f24e873)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - switch over the
NPM package to use CommonJS modules instead of ES modules.

- [#498](#498)
[`44f1ff7`](44f1ff7)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - flatten unnamed
CST nodes into parent nodes

- [#502](#502)
[`c383238`](c383238)
Thanks [@AntonyBlakey](https://github.com/AntonyBlakey)! - Use the Rowan
model for the CST i.e. TokenNodes contain the string content, and
RuleNodes contain only the combined _length_ of their children's text.

- [#499](#499)
[`1582d60`](1582d60)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - preserve correct
ranges on empty rule nodes

- [#500](#500)
[`73ddac9`](73ddac9)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - inlining CST
nodes that offer no additional syntactic information

- [#512](#512)
[`72dc3d3`](72dc3d3)
Thanks [@AntonyBlakey](https://github.com/AntonyBlakey)! - Expression
productions now correctly wrap the recursive 'calls' in a rule node

## changelog@0.7.0

### Minor Changes

- [#502](#502)
[`c383238`](c383238)
Thanks [@AntonyBlakey](https://github.com/AntonyBlakey)! - Added error
recovery i.e. a CST is _always_ produced, even if there are errors. The
erroneous/skipped text is in the CST as a `TokenKind::SKIPPED` token.

- [#501](#501)
[`cb221fe`](cb221fe)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - generate
typescript string enums for CST kinds

- [#517](#517)
[`8bd5446`](8bd5446)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - extract inlined
and sub-expressions in language grammar

- [#518](#518)
[`b3b562b`](b3b562b)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - fill in missing
CST node names

- [#515](#515)
[`f24e873`](f24e873)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - switch over the
NPM package to use CommonJS modules instead of ES modules.

- [#498](#498)
[`44f1ff7`](44f1ff7)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - flatten unnamed
CST nodes into parent nodes

- [#502](#502)
[`c383238`](c383238)
Thanks [@AntonyBlakey](https://github.com/AntonyBlakey)! - Use the Rowan
model for the CST i.e. TokenNodes contain the string content, and
RuleNodes contain only the combined _length_ of their children's text.

- [#499](#499)
[`1582d60`](1582d60)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - preserve correct
ranges on empty rule nodes

- [#500](#500)
[`73ddac9`](73ddac9)
Thanks [@OmarTawfik](https://github.com/OmarTawfik)! - inlining CST
nodes that offer no additional syntactic information

- [#512](#512)
[`72dc3d3`](72dc3d3)
Thanks [@AntonyBlakey](https://github.com/AntonyBlakey)! - Expression
productions now correctly wrap the recursive 'calls' in a rule node

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@OmarTawfik OmarTawfik self-assigned this Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants