Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply patch of latest commit in master for the dustflux output PR #420 to release1.6 branch #423

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

jmaerz
Copy link
Collaborator

@jmaerz jmaerz commented Oct 24, 2024

Hi @TomasTorsvik and @JorgSchwinger , this is the PR to replay the dustflux output commit #420 to the the release1.6 branch. I ended up using

git show HEAD > dust.patch
git apply --reject --ignore-whitespace dust.patch

which resulted in a few rejected hunks of the patch that then needed to be inserted manually. A cherrypick didn't work out for some reason.

@jmaerz jmaerz added this to the NorESM2.3 - BLOM/iHAMOCC milestone Oct 24, 2024
@jmaerz jmaerz self-assigned this Oct 24, 2024
@TomasTorsvik
Copy link
Contributor

@jmaerz - Thanks! This looks fine to me.
I still don't understand why the cherry-pick option didn't work, but I suspect it has something to do with how git compares changes introduced in the release-1.6 and master branches. The git-cherry-pick documentation describes what happens when git is unable to apply changes, which is the case we have run into here.
As the master branch develops further, it will likely become increasingly difficult to rely on cherry-picking changes back to the release-1.6 branch. Since fewer changes are introduced in release-1.6, I wonder if there may be less issues in applying patches from release-1.6 to master. Maybe something to test, if we have changes in the future that we know will go into both branches.

@jmaerz jmaerz merged commit 7abe0e0 into NorESMhub:release-1.6 Oct 25, 2024
6 checks passed
@jmaerz jmaerz deleted the release-1.6-dust branch October 25, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants