Dust fluxes output and add descriptions in the xml-namelist file #420
Conversation
…efinitions; fix preformed Si units in output
jmaerz
added
enhancement
hamocc/mo_bgcmean.F90
Outdated
| jdustflx2000(n)=i_bsc_m2d*min(1,FLX_DUST2000(n)) | ||
| if (FLX_DUST4000(n) > 0) i_bsc_m2d=i_bsc_m2d+1 | ||
| jdustflx4000(n)=i_bsc_m2d*min(1,FLX_DUST4000(n)) | ||
| if (FLX_CAL_BOT(n) > 0) i_bsc_m2d=i_bsc_m2d+1 |
There was a problem hiding this comment.
This should be FLX_DUST_BOT(n)!
There was a problem hiding this comment.
Thanks for catching this!
| call wrtsrf(jdustflx1000(iogrp), FLX_DUST1000(iogrp), rnacc*1e3/dtbgc,0.,cmpflg,'dustflx1000') | ||
| call wrtsrf(jdustflx2000(iogrp), FLX_DUST2000(iogrp), rnacc*1e3/dtbgc,0.,cmpflg,'dustflx2000') | ||
| call wrtsrf(jdustflx4000(iogrp), FLX_DUST4000(iogrp), rnacc*1e3/dtbgc,0.,cmpflg,'dustflx4000') | ||
| call wrtsrf(jdustflx_bot(iogrp), FLX_DUST_BOT(iogrp), rnacc*1e3/dtbgc,0.,cmpflg,'dustflx_bot') |
There was a problem hiding this comment.
Did you check that the 1e3 is correct here? Usually this converts from kmol -> mol, is it here from kg -> g?
There was a problem hiding this comment.
Yes, it's from kg -> g.
|
Looks fine for me, but I will hold off on the review until the PR is updated with namelist option. |
…enable selection of sinking scheme - default: WLIN
|
Hi @JorgSchwinger and @TomasTorsvik , I tinkered around with the component settings and the xml-namelist and found a way to get to the wanted behavior by making changes to I introduced a new xmlchange switch named I hope that satisfies the needs that we have. Tomas an I, we discussed that we could introduce another small subroutine that allows to replace all the different places of |
|
Looks fine, thank you. |
#423) Introduction of dustflux output and of a xml-switch HAMOCC_SINKING_SCHEME with options WLIN, AGG, M4AGO and CONST, default is WLIN, to select a sinking scheme in iHAMOCC.
Hi @TomasTorsvik and @JorgSchwinger , as discussed, this PR brings in dust output and some descriptions in the xml-namelist file. I tried to fill all iHAMOCC gaps to my best knowledge. I cleaned the way, M4AGO sinking velocity is handled in
mo_ocprod(wasn't ideal before).Together with this PR, I introduced the xmlchange switch
HAMOCC_SINKING_SCHEME(and removed the compset HAMOCC_M4AGO switch) that allows to select among the four supported sinking schemes: [WLIN, AGG, M4AGO, CONST], the default remains WLIN.Ideally, this PR also enters the v1.6.x release version. Sorry for this delayed PR for the release tag - it just adds some potentially valuable output (and provides a more descriptive iHAMOCC xml-namelist definition file).