NSM connection (VIPs and routes) update in TAPA #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What version of NSM is required? Not v1.2.0 I assume? |
|
It requires the latest version in the main branch of the nsmgr and forwarder-vpp + this PR: networkservicemesh/sdk-kernel#433. Also, the NSM dependencies of Meridio must be updated (will be done in a separate PR when NSM 1.3 will be available). |
* The initial NSM request does not contain any information about the ip context. Once the conduit connected (sucessful NSM request), the VIP watcher will call SetVIPs which will update (new request) the NSM connection (SrcIPs and policies). * the initial SrcIPs are saved in the conduit struct (to not mix the target IPs and VIPs) * The previous code has been removed
* The last privileges required (NET_ADMIN) has been removed
|
I rebased master, NSM has been uplifted and all PRs requireed are merged. |
|
Can't say much about the code since my NSM knowledge is limited but I have applied this PR, built and tested and it seem to work fine. The |
uablrek
approved these changes
Apr 4, 2022
zolug
reviewed
Apr 8, 2022
zolug
reviewed
Apr 8, 2022
| vipsSlice = append(vipsSlice, vip) | ||
| var err error | ||
| // update the NSM connection | ||
| // TODO: retry if error returned? |
There was a problem hiding this comment.
maybe nsm's retry client could come handy here
zolug
approved these changes
Apr 8, 2022
zolug
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial NSM request does not contain any information about the ip context. Once the conduit connected (sucessful NSM request), the VIP watcher will call SetVIPs which will update (new request) the NSM connection (SrcIPs and policies).
The initial SrcIPs are saved in the conduit struct (to not mix the target IPs and VIPs).
The previous code has been removed.
The last privileges required (NET_ADMIN) has been removed.
issue: #164
related NSM issues:
Changes required before merging: