Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NSM uplift to 1.3.0-rc.1 #188

Merged
merged 1 commit into from
Mar 30, 2022
Merged

NSM uplift to 1.3.0-rc.1 #188

merged 1 commit into from
Mar 30, 2022

Conversation

LionelJouin
Copy link
Member

No description provided.

@LionelJouin LionelJouin mentioned this pull request Mar 29, 2022
Merged
@LionelJouin LionelJouin marked this pull request as ready for review March 29, 2022 13:34
@LionelJouin LionelJouin mentioned this pull request Mar 29, 2022
Merged
uablrek
uablrek approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@uablrek uablrek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-built images and tested.

@LionelJouin LionelJouin merged commit 916aee7 into master Mar 30, 2022
@LionelJouin LionelJouin deleted the nsm-1-3-uplift branch March 30, 2022 08:02
@uablrek
Copy link
Contributor

uablrek commented Mar 31, 2022

Tests were made with NSM images v1.2.0, but with this PR applied. NSM v1.3.0-rc.1 seems broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uablrek uablrek uablrek approved these changes

@zolug zolug Awaiting requested review from zolug

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LionelJouin @uablrek