Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch markdownlint container to markdownlint-cli2 #93

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

tuminoid
Copy link
Member

@tuminoid tuminoid commented Jan 18, 2024

Switch markdownlint container to markdownlint-cli2. This CLI version supports the enable/disable rules in markdown files and allows us to ignore issues locally, not just globally.

@tuminoid tuminoid force-pushed the tuomo/switch-to-markdownlint-cli2 branch from f2c8181 to db34cdf Compare January 23, 2024 12:42
@tuminoid tuminoid changed the title WIP: switch markdownlint container to markdownlint-cli2 switch markdownlint container to markdownlint-cli2 Jan 23, 2024
@tuminoid
Copy link
Member Author

/hold
Needs metal3-io/project-infra#619 to merge first.

lentzi90
lentzi90 previously approved these changes Jan 24, 2024
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

TODO: line-length issues to be fixed later

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@tuminoid
Copy link
Member Author

Bumped to 0.9.0 release of the image from 2 days ago.

Copy link
Contributor

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Member

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest, lentzi90, smoshiur1237

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kashifest,lentzi90,smoshiur1237]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tuminoid
Copy link
Member Author

/retest
Test new linter.

@tuminoid
Copy link
Member Author

/unhold
Good to go.

@metal3-io-bot metal3-io-bot merged commit c1e7a06 into main Jan 24, 2024
4 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/switch-to-markdownlint-cli2 branch January 24, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants