Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch markdownlint container to markdownlint-cli2 #619

Merged
merged 1 commit into from
Jan 24, 2024
Merged

switch markdownlint container to markdownlint-cli2 #619

merged 1 commit into from
Jan 24, 2024

Conversation

tuminoid
Copy link
Member

@tuminoid tuminoid commented Jan 18, 2024 •
edited
Loading

Switch markdownlint container to markdownlint-cli2. This CLI version supports the enable/disable rules in markdown files and allows us to ignore issues locally, not just globally.

TODO:

  1. we need to get each of the reviews pointing at this to be approved, lgtm'd and held; the larger the batch the better
  2. we need to merge this in one more multiple pieces (more likely)

@metal3-io-bot metal3-io-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 18, 2024
@tuminoid tuminoid force-pushed the tuomo/switch-to-markdownlint-cli2 branch from f1337a6 to df859ae Compare January 18, 2024 13:03
@metal3-io-bot metal3-io-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 18, 2024
@tuminoid tuminoid force-pushed the tuomo/switch-to-markdownlint-cli2 branch 3 times, most recently from eb0d391 to 784f030 Compare January 23, 2024 12:39
This was referenced Jan 23, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@tuminoid tuminoid changed the title WIP: switch markdownlint container to markdownlint-cli2 switch markdownlint container to markdownlint-cli2 Jan 23, 2024
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 23, 2024
This was referenced Jan 23, 2024
Merged
Merged
Merged
Merged
smoshiur1237
smoshiur1237 reviewed Jan 23, 2024
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2024
@tuminoid
Copy link
Member Author

/hold
Needs to merge part of this for itself first, and probably split to portions to merge with others.

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 23, 2024
lentzi90
lentzi90 reviewed Jan 24, 2024
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2024
@tuminoid tuminoid force-pushed the tuomo/switch-to-markdownlint-cli2 branch from 784f030 to 4b86c5c Compare January 24, 2024 10:36
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2024
@tuminoid
switch markdownlint container to markdownlint-cli2
6902cea 
For the repo itself, switch the hack/markdownlint.sh over.

For the Prow config:
- switch over the main branches of repos with release branches
- release branches stay with the old implementation
- add config for Ironic-client, adding shellcheck+markdownlint
- add shellcheck for metal3-io.github.io as we're replacing
  prettier+shfmt from pre-commit to this+shellcheck

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@tuminoid tuminoid force-pushed the tuomo/switch-to-markdownlint-cli2 branch from 4b86c5c to 6902cea Compare January 24, 2024 10:38
@tuminoid tuminoid mentioned this pull request Jan 24, 2024
Merged
@tuminoid
Copy link
Member Author

Bumped to 0.9.0 release of the image from 2 days ago.
Added metal3-io.github.io into Prow config for metal3-io/metal3-io.github.io#390

smoshiur1237
smoshiur1237 reviewed Jan 24, 2024
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2024
@tuminoid
Copy link
Member Author

/override markdownlint test-ubuntu-integration-main

@metal3-io-bot
Copy link
Collaborator

@tuminoid: Overrode contexts on behalf of tuminoid: markdownlint, test-ubuntu-integration-main

In response to this:

/override markdownlint test-ubuntu-integration-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tuminoid
Copy link
Member Author

Here we go.
/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2024
@metal3-io-bot metal3-io-bot merged commit 72e1509 into metal3-io:main Jan 24, 2024
7 checks passed
@metal3-io-bot
Copy link
Collaborator

@tuminoid: Updated the config configmap in namespace prow at cluster default using the following files:

  • key config.yaml using file prow/manifests/overlays/metal3/config.yaml

In response to this:

Switch markdownlint container to markdownlint-cli2. This CLI version supports the enable/disable rules in markdown files and allows us to ignore issues locally, not just globally.

TODO:

  1. we need to get each of the reviews pointing at this to be approved, lgtm'd and held; the larger the batch the better
  2. we need to merge this in one more multiple pieces (more likely)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tuminoid tuminoid deleted the tuomo/switch-to-markdownlint-cli2 branch January 24, 2024 14:19
@tuminoid tuminoid mentioned this pull request Jan 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

@smoshiur1237 smoshiur1237 smoshiur1237 left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tuminoid @metal3-io-bot @lentzi90 @smoshiur1237