Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add markdownlint-cli2 for linting markdown #17

Merged

Conversation

tuminoid
Copy link
Member

@tuminoid tuminoid commented Jan 18, 2024

Add markdownlint linter via markdownline-cli2. This CLI version supports the enable/disable rules in markdown files and allows us to ignore issues locally, not just globally.

@metal3-io-bot metal3-io-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 18, 2024
@tuminoid tuminoid force-pushed the tuomo/switch-to-markdownlint-cli2 branch 5 times, most recently from e71f50d to aab59aa Compare January 23, 2024 13:34
@tuminoid tuminoid changed the title WIP: add markdownlint-cli2 for linting markdown add markdownlint-cli2 for linting markdown Jan 23, 2024
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 23, 2024
@tuminoid
Copy link
Member Author

/hold
Needs metal3-io/project-infra#619 to merge first.

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 23, 2024
@tuminoid tuminoid force-pushed the tuomo/switch-to-markdownlint-cli2 branch from aab59aa to a2099d1 Compare January 24, 2024 10:40
@tuminoid
Copy link
Member Author

Bumped to 0.9.0 release of the image from 2 days ago.

@dtantsur
Copy link
Member

/approve
/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2024
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2024
@tuminoid
Copy link
Member Author

/retest
Test new linters.

Add also shellcheck to check the linter scripts.

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@tuminoid tuminoid force-pushed the tuomo/switch-to-markdownlint-cli2 branch from a2099d1 to 6da7727 Compare January 24, 2024 14:33
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2024
@dtantsur
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2024
@tuminoid
Copy link
Member Author

Thanks!
/unhold
Good to go.

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2024
@metal3-io-bot metal3-io-bot merged commit 4de85c1 into metal3-io:main Jan 24, 2024
4 checks passed
@tuminoid tuminoid deleted the tuomo/switch-to-markdownlint-cli2 branch January 24, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants