Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch markdownlint container to markdownlint-cli2 #743

Merged
merged 1 commit into from
Jan 24, 2024
Merged

switch markdownlint container to markdownlint-cli2 #743

merged 1 commit into from
Jan 24, 2024

Conversation

tuminoid
Copy link
Member

@tuminoid tuminoid commented Jan 23, 2024 •
edited
Loading

Also fix or locally ignore markdownlint issues.

@tuminoid tuminoid force-pushed the tuomo/switch-to-markdownlint-cli2 branch from fb42513 to 9165165 Compare January 23, 2024 08:20
@tuminoid tuminoid force-pushed the tuomo/switch-to-markdownlint-cli2 branch 3 times, most recently from 54689e3 to 34d4c8d Compare January 23, 2024 12:38
@tuminoid tuminoid changed the title WIP: switch markdownlint container to markdownlint-cli2 switch markdownlint container to markdownlint-cli2 Jan 23, 2024
Sunnatillo
Sunnatillo previously approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

smoshiur1237
smoshiur1237 previously approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@tuminoid
Copy link
Member Author

/hold
Needs metal3-io/project-infra#619 to merge first.

lentzi90
lentzi90 previously approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nits, but I will put approve already
/approve

wow/github-workflow.md Show resolved Hide resolved
wow/github-workflow.md Outdated Show resolved Hide resolved
@tuminoid tuminoid force-pushed the tuomo/switch-to-markdownlint-cli2 branch from 34d4c8d to 5c469d7 Compare January 24, 2024 10:46
@tuminoid
switch markdownlint container to markdownlint-cli2
ff375ca 
Also fix or locally ignore markdownlint issues.

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@tuminoid tuminoid force-pushed the tuomo/switch-to-markdownlint-cli2 branch from 5c469d7 to ff375ca Compare January 24, 2024 11:29
@tuminoid
Copy link
Member Author

Nits fixed and bumped to newer release 0.9.0 from 2 days ago.

smoshiur1237
smoshiur1237 approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sunnatillo
Sunnatillo approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

kashifest
kashifest approved these changes Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Member

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest, lentzi90, smoshiur1237, Sunnatillo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Sunnatillo,kashifest,lentzi90,smoshiur1237]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tuminoid
Copy link
Member Author

/retest
Test new linters.

@tuminoid
Copy link
Member Author

/override test-integration-metal3-dev-tools-centos test-integration-metal3-dev-tools-ubuntu

@metal3-io-bot
Copy link
Member

@tuminoid: Overrode contexts on behalf of tuminoid: test-integration-metal3-dev-tools-centos, test-integration-metal3-dev-tools-ubuntu

In response to this:

/override test-integration-metal3-dev-tools-centos test-integration-metal3-dev-tools-ubuntu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tuminoid
Copy link
Member Author

/test markdownlint

@metal3-io-bot
Copy link
Member

@tuminoid: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test shellcheck

Use /test all to run all jobs.

In response to this:

/test markdownlint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tuminoid
Copy link
Member Author

Project-infra is missing markdownlint for this repo: adding it in metal3-io/project-infra#623

@tuminoid
Copy link
Member Author

/retest

@tuminoid
Copy link
Member Author

/unhold
Good to go.

@metal3-io-bot metal3-io-bot merged commit b0981da into main Jan 24, 2024
5 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/switch-to-markdownlint-cli2 branch January 24, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sunnatillo Sunnatillo Sunnatillo approved these changes

@kashifest kashifest kashifest approved these changes

@smoshiur1237 smoshiur1237 smoshiur1237 approved these changes

@lentzi90 lentzi90 lentzi90 left review comments

Assignees

@Sunnatillo Sunnatillo

@smoshiur1237 smoshiur1237

Labels
approved lgtm size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tuminoid @metal3-io-bot @lentzi90 @Sunnatillo @kashifest @smoshiur1237