Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add markdownlint for dev-tools repo #623

Merged
merged 1 commit into from
Jan 24, 2024
Merged

add markdownlint for dev-tools repo #623

merged 1 commit into from
Jan 24, 2024

Conversation

tuminoid
Copy link
Member

It was completely missing.

@tuminoid
add markdownlint for dev-tools repo
c688c39 
It was completely missing.

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 24, 2024
@tuminoid
Copy link
Member Author

/override test-ubuntu-integration-main

@metal3-io-bot
Copy link
Collaborator

@tuminoid: Overrode contexts on behalf of tuminoid: test-ubuntu-integration-main

In response to this:

/override test-ubuntu-integration-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tuminoid tuminoid mentioned this pull request Jan 24, 2024
Merged
Sunnatillo
Sunnatillo reviewed Jan 24, 2024
View reviewed changes
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2024
smoshiur1237
smoshiur1237 reviewed Jan 24, 2024
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

kashifest
kashifest approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2024
@metal3-io-bot metal3-io-bot merged commit 9f645d5 into metal3-io:main Jan 24, 2024
5 checks passed
@metal3-io-bot
Copy link
Collaborator

@tuminoid: Updated the config configmap in namespace prow at cluster default using the following files:

  • key config.yaml using file prow/manifests/overlays/metal3/config.yaml

In response to this:

It was completely missing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tuminoid tuminoid deleted the tuomo/add-markdownlint-for-dev-tools branch January 24, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sunnatillo Sunnatillo Sunnatillo left review comments

@smoshiur1237 smoshiur1237 smoshiur1237 left review comments

@kashifest kashifest kashifest approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tuminoid @metal3-io-bot @Sunnatillo @kashifest @smoshiur1237