Skip to content

Commit

Permalink
Feat/upgrade node ts (#167)
Browse files Browse the repository at this point in the history
* upgrade ts and node

* upgrade ts eslint to the version that supports ts 5.4

* upgrade vue-tsc to fix build fail bug

* fix failing test, see microsoft/playwright/issues/16834

* upgrade pnpm and node actions version

* specify node ver for cloudflare pages by add file .node-version
  • Loading branch information
uier authored Mar 21, 2024
1 parent d5914a9 commit 9b1ac1d
Show file tree
Hide file tree
Showing 7 changed files with 361 additions and 275 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/lint-ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@ jobs:

steps:
- uses: actions/checkout@v3
- uses: pnpm/action-setup@v2
- uses: pnpm/action-setup@v3
with:
version: 8.6
- name: Use Node.js v16.x
uses: actions/setup-node@v3
- name: Use Node.js v20.x
uses: actions/setup-node@v4
with:
node-version: "16.x"
node-version: "20.x"
cache: 'pnpm'
- name: Install dependencies
run: pnpm install --frozen-lockfile
Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/playwright.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,13 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: pnpm/action-setup@v2
- uses: pnpm/action-setup@v3
with:
version: 8.6
- name: Use Node.js v16.x
uses: actions/setup-node@v3
- name: Use Node.js v20.x
uses: actions/setup-node@v4
with:
node-version: "16.x"
node-version: "20.x"
cache: "pnpm"
- name: Install dependencies
run: pnpm install
Expand All @@ -54,10 +54,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Use Node.js v16.x
uses: actions/setup-node@v3
- name: Use Node.js v20.x
uses: actions/setup-node@v4
with:
node-version: "16.x"
node-version: "20.x"
- name: Setup Pages
uses: actions/configure-pages@v3
- name: Download test report
Expand Down
1 change: 1 addition & 0 deletions .node-version
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
20.10.0
12 changes: 6 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,27 +42,27 @@
},
"devDependencies": {
"@iconify-json/uil": "^1.1.0",
"@playwright/test": "^1.34.3",
"@playwright/test": "^1.42.1",
"@types/dompurify": "^2.3.3",
"@types/katex": "^0.11.1",
"@types/markdown-it": "^12.2.3",
"@types/node": "^18.11.18",
"@types/scrollmagic": "^2.0.3",
"@typescript-eslint/eslint-plugin": "^5.56.0",
"@typescript-eslint/parser": "^5.56.0",
"@typescript-eslint/eslint-plugin": "^7.2.0",
"@typescript-eslint/parser": "^7.2.0",
"@vitejs/plugin-vue": "^4.0.0",
"autoprefixer": "^10.4.2",
"eslint": "^8.7.0",
"eslint": "^8.57.0",
"eslint-config-prettier": "^8.3.0",
"postcss": "^8.4.6",
"prettier": "^2.8.2",
"prettier-plugin-tailwindcss": "^0.1.13",
"tailwindcss": "^3.0.23",
"typescript": "^5.0.4",
"typescript": "^5.4.2",
"unplugin-icons": "^0.15.1",
"unplugin-vue-components": "^0.22.12",
"vite": "^4.0.4",
"vite-plugin-pages": "^0.28.0",
"vue-tsc": "^1.0.24"
"vue-tsc": "^1.8.27"
}
}
4 changes: 2 additions & 2 deletions playwright.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export default defineConfig({
/* Shared settings for all the projects below. See https://playwright.dev/docs/api/class-testoptions. */
use: {
/* Base URL to use in actions like `await page.goto('/')`. */
baseURL: "http://127.0.0.1:3000",
baseURL: "http://localhost:3000",

/* Collect trace when retrying the failed test. See https://playwright.dev/docs/trace-viewer */
trace: "on-first-retry",
Expand Down Expand Up @@ -72,7 +72,7 @@ export default defineConfig({

webServer: {
command: "NODE_ENV=test pnpm preview --port 3000",
url: "http://127.0.0.1:3000",
url: "http://localhost:3000",
reuseExistingServer: !process.env.CI,
},
});
Loading

0 comments on commit 9b1ac1d

Please sign in to comment.