Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/upgrade node ts #167

Merged
merged 6 commits into from
Mar 21, 2024
Merged

Feat/upgrade node ts #167

merged 6 commits into from
Mar 21, 2024

Conversation

uier
Copy link
Member

@uier uier commented Mar 18, 2024

fix #164 #151

@uier uier requested a review from Bogay March 18, 2024 10:47
@uier uier self-assigned this Mar 18, 2024
Copy link

cloudflare-workers-and-pages bot commented Mar 18, 2024

Deploying nfe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 549b052
Status: ✅  Deploy successful!
Preview URL: https://562071c5.nfe.pages.dev
Branch Preview URL: https://feat-upgrade-node-ts.nfe.pages.dev

View logs

@uier
Copy link
Member Author

uier commented Mar 18, 2024

oh, seems the failing test can be reproduced on my local machine.

@uier
Copy link
Member Author

uier commented Mar 18, 2024

127.0.0.1 -> localhost,原因不明,但此問題升級 node v20 後才發生
microsoft/playwright#16834

Copy link
Contributor

@laporchen laporchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No breaking changes from 16 -> 20 it seems

.github/workflows/lint-ci.yaml Outdated Show resolved Hide resolved
.github/workflows/playwright.yml Outdated Show resolved Hide resolved
@uier
Copy link
Member Author

uier commented Mar 21, 2024

Upgrade node ver on Cloudflare (by changing env) before merging this into main

@uier
Copy link
Member Author

uier commented Mar 21, 2024

based on https://developers.cloudflare.com/pages/configuration/language-support-and-tools/

Many common tools have been preinstalled in the Cloudflare Pages build environment.

, including pnpm (v8.7.1 at this time)

by setting a NODE_VERSION environment variable or by adding a .node-version

@uier uier merged commit 9b1ac1d into main Mar 21, 2024
4 checks passed
@Bogay Bogay mentioned this pull request Mar 22, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade typescript to support Array toReversed
3 participants