Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backend] - Delete WPs should accept a change request ID #1587

Closed
ninest opened this issue Oct 3, 2023 · 0 comments · Fixed by #2648
Closed

[Backend] - Delete WPs should accept a change request ID #1587

ninest opened this issue Oct 3, 2023 · 0 comments · Fixed by #2648
Assignees
@tigerhippo
Labels
back-end medium stale Hasn't been updated in a while

Comments

@ninest
Copy link
Member

ninest commented Oct 3, 2023 •
edited
Loading

Make these changes on a new branch: feature/cr-delete-wp

Description

Currently, deleting WPs does not require a change request ID.

Acceptance Criteria

Deleting WPs should accept a crID and a change should be implemented.

  • Backend: the delete WP endpoint should accept a crID
  • Before the WP is deleted, the change has to be implemented for the deleted WP

Proposed Solution

  • work-packages.routes.ts: delete route should take a CR ID
  • work-packages.controllers.ts:
  • work-packages.services.ts: delete WP service: Create a change, then delete the WP
@ninest ninest added back-end medium new feature New feature or request and removed new feature New feature or request labels Oct 3, 2023
@ninest ninest mentioned this issue Oct 3, 2023
Open
@github-actions github-actions bot added the stale Hasn't been updated in a while label Apr 12, 2024
@tigerhippo tigerhippo self-assigned this May 3, 2024
@Peyton-McKee Peyton-McKee removed the stale Hasn't been updated in a while label May 5, 2024
tigerhippo pushed a commit that referenced this issue May 9, 2024
#1587: obtained and passed in crId
85022b7
tigerhippo pushed a commit that referenced this issue May 14, 2024
#1587: updated delete route function
08520b2
tigerhippo pushed a commit that referenced this issue May 17, 2024
#1587: called function to validate change request
1a94d41
@Peyton-McKee Peyton-McKee moved this from Todo to In Progress in FinishLine Project Board May 19, 2024
@github-actions github-actions bot added the stale Hasn't been updated in a while label May 20, 2024
tigerhippo pushed a commit that referenced this issue May 22, 2024
#1587: change created on CR for deleted WP
3cdee72
@tigerhippo tigerhippo mentioned this issue May 22, 2024
Closed
11 tasks
tigerhippo pushed a commit that referenced this issue May 24, 2024
#1587: fixed errors pertaining to deleteWorkPackage method calls
3e4e0d5
@tigerhippo tigerhippo mentioned this issue May 25, 2024
Closed
14 tasks
tigerhippo pushed a commit that referenced this issue May 26, 2024
#1587: merged develop into my branch and fixed merge conflicts
27e20d5
tigerhippo pushed a commit that referenced this issue May 26, 2024
#1587: deleted mocked tests folder
d1a2cc1
Zwendle added a commit that referenced this issue May 27, 2024
@Zwendle
#1587: Prettier formatting
907892e
tigerhippo pushed a commit that referenced this issue May 27, 2024
#1587: fixed prettier hopefully for real this time
2e1a7d8
tigerhippo pushed a commit that referenced this issue May 31, 2024
#1587: fixed unnecessary return statement in deleteWorkPackage contro…
2dccbd1 
…ller function
@Peyton-McKee Peyton-McKee moved this from In Progress to Under Review in FinishLine Project Board Jun 1, 2024
tigerhippo pushed a commit that referenced this issue Jun 3, 2024
#1587: copied changes from old branch to this branch
65a8ff8
@tigerhippo tigerhippo mentioned this issue Jun 5, 2024
Merged
11 tasks
tigerhippo pushed a commit that referenced this issue Jun 5, 2024
#1587: added a crId to deleteProject endpoint and changed comments
8647909
walker-sean added a commit that referenced this issue Jun 11, 2024
@walker-sean
Merge pull request #2648 from Northeastern-Electric-Racing/#feature/c…
19a18f7 
…r-delete-wp

#1587: Delete WP takes CR id
@github-project-automation github-project-automation bot moved this from Under Review to Done in FinishLine Project Board Jun 11, 2024
walker-sean added a commit that referenced this issue Jun 11, 2024
@walker-sean
Revert "#1587: Copied Changes from old branch to this branch"
3ae9d6c
walker-sean added a commit that referenced this issue Jun 11, 2024
@walker-sean
Merge pull request #2661 from Northeastern-Electric-Racing/revert-264…
ba47496 
…8-#feature/cr-delete-wp

Revert "#1587: Copied Changes from old branch to this branch"
tigerhippo pushed a commit that referenced this issue Jun 12, 2024
#1587: added everything from previous wrong branch (made off of develop)
f144de6
@tigerhippo tigerhippo mentioned this issue Jun 12, 2024
Merged
11 tasks
tigerhippo pushed a commit that referenced this issue Jun 24, 2024
#1587: got rid of identifier where it shouldn't be used and updated t…
24fbdf2 
…he name to changeRequestIdentifier
tigerhippo pushed a commit that referenced this issue Jul 2, 2024
#1587: replaced more instances of crId with identifier and called fun…
ce05f8d 
…ction to get the crId using the identifier
tigerhippo pushed a commit that referenced this issue Jul 3, 2024
#1587: fixing failing prettier checks
95a16a9
tigerhippo pushed a commit that referenced this issue Jul 8, 2024
#1587: changed nonEmptyString() to intMinZero() with validateInputs
90ee481
tigerhippo pushed a commit that referenced this issue Jul 31, 2024
#1587: notes on what to fix
bc0dd7e
tigerhippo pushed a commit that referenced this issue Aug 1, 2024
#1587: revised findFirst to FindUnique and changed exclamation mark i…
6616f80 
…n front of changeRequest to an if statement that checks if null
tigerhippo pushed a commit that referenced this issue Aug 2, 2024
#1587: fixed prettier
8d1f033
tigerhippo pushed a commit that referenced this issue Aug 8, 2024
#1587: changed order of function calls within deleteProject service f…
dabe0eb 
…unction and deleted code that deleted a change requests in deleteWorkPackage service function
tigerhippo pushed a commit that referenced this issue Aug 8, 2024
#1587: fixed prettier
6f37958
tigerhippo pushed a commit that referenced this issue Aug 8, 2024
#1587: fixed prettier for real
340daa9
tigerhippo pushed a commit that referenced this issue Aug 13, 2024
#1587: preventing error from being thrown in deleteProject function i…
31137c9 
…f any of the work packages of that project were deleted already
tigerhippo pushed a commit that referenced this issue Aug 18, 2024
#1587: checked if change request is null to throw NotFoundException, …
a730a78 
…and then checked for date deleted to throw DeletedException
walker-sean added a commit that referenced this issue Aug 19, 2024
@walker-sean
Merge pull request #2662 from Northeastern-Electric-Racing/#1587-dele…
7e46eae 
…te-WPs-should-accept-crID

#1587: added everything from previous wrong branch (made off of develop)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tigerhippo tigerhippo

Labels
back-end medium stale Hasn't been updated in a while
Projects
FinishLine Project Board
Archived in project
Milestone
No milestone
4 participants
@ninest @tigerhippo @yulanwang @Peyton-McKee