Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete WPs Should Accept a CR ID #2604

Closed
wants to merge 11 commits into from
Closed

Conversation

tigerhippo
Copy link

@tigerhippo tigerhippo commented May 25, 2024

Changes

  • work-packages.routes.ts delete route takes in a CR ID
  • work-packages.controllers.ts delete method gets CR ID from request body and passes that into the service function
  • work-packages.services.ts delete method takes in CR ID, makes a Change on the CR corresponding to the given CR ID (which states that the WP is deleted), then soft deletes the WP

Test Cases

  • yarn test:frontend works

To Do

  • Fix failing TypeScript checks
  • Fix wrong argument being passed into deleteWorkPackage function (in the deleteProject function) by adding a crId param to the deleteProject endpoint
  • Manually test to make sure FinishLine still works

Checklist

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #1587

@tigerhippo tigerhippo self-assigned this May 25, 2024
@tigerhippo tigerhippo closed this Jun 3, 2024
@tigerhippo tigerhippo deleted the #feature/cr-delete-wp branch June 3, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Backend] - Delete WPs should accept a change request ID
2 participants