Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2709 set up new guest home page #2722

Merged
merged 29 commits into from
Aug 24, 2024
Merged

#2709 set up new guest home page #2722

merged 29 commits into from
Aug 24, 2024

Conversation

Aaryan1203
Copy link
Contributor

@Aaryan1203 Aaryan1203 commented Jul 20, 2024

Changes

  • New guest page when using a guest user.
  • When you click learn more, it sends you to the normal homepage
  • sidebar is hidden on the guest homepage
  • new user named spongebob as a guest user because we didn't have one
  • reorganized the homepage files

Screenshots

This is the current guest page
image

To Do

  • Add the two pictures and buttons so it matches the mocks

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #2709

@Aaryan1203 Aaryan1203 self-assigned this Jul 20, 2024
Copy link
Member

@walker-sean walker-sean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

src/frontend/src/app/AppAuthenticated.tsx Outdated Show resolved Hide resolved
src/frontend/src/app/AppAuthenticated.tsx Outdated Show resolved Hide resolved
src/frontend/src/app/AppAuthenticated.tsx Outdated Show resolved Hide resolved
src/frontend/src/pages/HomePage/GuestHomePage.tsx Outdated Show resolved Hide resolved
src/frontend/src/app/AppAuthenticated.tsx Outdated Show resolved Hide resolved
src/frontend/src/app/AppAuthenticated.tsx Outdated Show resolved Hide resolved
src/frontend/src/app/AppAuthenticated.tsx Outdated Show resolved Hide resolved
src/frontend/src/pages/HomePage/Home.tsx Outdated Show resolved Hide resolved
Copy link
Member

@walker-sean walker-sean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@walker-sean walker-sean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I forgot about the images, let's get the images seeded and then get the images to display on the home page

Copy link
Member

@walker-sean walker-sean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh lol its a ticket nvm

@walker-sean walker-sean merged commit eded39e into develop Aug 24, 2024
4 checks passed
@walker-sean walker-sean deleted the #2709-new-welcome-page branch August 24, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Recruitment] - Create New Welcome Page
4 participants