Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PackageSigning - "nuget.exe sign" - Allow package authors to sign packages #5904

Closed
mishra14 opened this issue Sep 19, 2017 · 2 comments
Closed

PackageSigning - "nuget.exe sign" - Allow package authors to sign packages #5904

mishra14 opened this issue Sep 19, 2017 · 2 comments
Assignees
@mishra14
Labels
Functionality:Signing Product:NuGet.exe NuGet.exe Type:Feature
Milestone
4.6 - Oct24-Nov11

Comments

@mishra14
Copy link
Contributor

mishra14 commented Sep 19, 2017 •
edited
Loading

Goal: As part of the larger package signing task, we need to add support to allow package authors to sign their packages before publishing.

Spec: In review - #5907
@mishra14 mishra14 added this to the 4.5 milestone Sep 19, 2017
@mishra14 mishra14 mentioned this issue Sep 19, 2017
Closed
@mishra14 mishra14 mentioned this issue Sep 29, 2017
Closed
@mishra14 mishra14 self-assigned this Sep 29, 2017
@mishra14 mishra14 modified the milestones: 4.5, 4.5 - Oct3-Oct21 Sep 29, 2017
mishra14 pushed a commit to NuGet/NuGet.Client that referenced this issue Oct 20, 2017
Adding support for NuGet.exe sign command with fake signing (#1755)
fed8530 
## Bug
Link: Contributes to NuGet/Home#5904
Regression: No  

## Fix
Details: Adds a top level command to NuGet.exe to allow authors to sign packages with fake signing. The behavior is documented in the [spec](https://github.com/NuGet/Home/wiki/NuGet-Sign-Command).

## Testing/Validation
Tests Added: Yes
Validation done:  Manually tested NuGet.exe
@mishra14
Copy link
Contributor Author

Current implementation for fake/mock signing is into the feature branch. Will get back to this after the signing APIs are ready. Updating estimate to reflect the new milestone.

@mishra14 mishra14 modified the milestones: 4.5 - Oct3-Oct21, 4.5 - Oct24-Nov11 Oct 20, 2017
@rrelyea rrelyea added the Product:NuGet.exe NuGet.exe label Oct 23, 2017
@rrelyea rrelyea changed the title [Feature]: Add support to allow package authors to sign packages [Feature]: Add support to allow package authors to sign packages - "nuget.exe sign" Oct 23, 2017
This was referenced Nov 13, 2017
Closed
Closed
@mishra14 mishra14 mentioned this issue Nov 29, 2017
Merged
mishra14 pushed a commit to NuGet/NuGet.Client that referenced this issue Nov 29, 2017
Add support to allow users to input password through commandline to s…
065262c 
…ign command (#1824)

## Bug
Fixes: NuGet/Home#5904
Regression: No

## Fix
Details: This PR adds support in sign command to allow users to interactively type pfx file password securely. To allow this I have added  `IPasswordProvider.cs` and its implementation `ConsolePasswordProvider.cs` that allows `SignCommandRunner` to read password from console in `-NonInteractive` mode. The underlying implementation comes from `IConsole.ReadSecureString`.

I have also added some tests using pfx files and done some cleanup in the test code.

## Testing/Validation
Tests Added: Yes
Validation done:  manual testing with pfx files.
@mishra14
Copy link
Contributor Author

mishra14 commented Nov 30, 2017 •
edited
Loading

Last piece checked in with NuGet/NuGet.Client@065262c

@rrelyea rrelyea changed the title [Feature]: Add support to allow package authors to sign packages - "nuget.exe sign" PackageSigning - "nuget.exe sign" - Allow package authors to sign packages Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mishra14 mishra14

Labels
Functionality:Signing Product:NuGet.exe NuGet.exe Type:Feature
Projects
None yet
Milestone
4.6 - Oct24-Nov11
Development

No branches or pull requests
2 participants
@rrelyea @mishra14