"Package Integrity check failed." should have package ID in message (and error code) #6944
Assignees
Labels
Area:ErrorHandling
warnings and errors/log messages & related error codes.
Functionality:Signing
Priority:1
High priority issues that must be resolved in the current sprint.
Type:Bug
Milestone
Comments
mishra14
added
the
Area:ErrorHandling
mishra14
added
the
Priority:1
mishra14
pushed a commit
to NuGet/NuGet.Client
that referenced
this issue
Jun 27, 2018
…#2313) ## Bug Fixes: Half of NuGet/Home#6944 Regression: No ## Fix This PR fixes the following - 1. During install, errors logged in the error list did not contain error code. Fixing this by adding a `ErrorListTableDataSource` in `OutputConsoleLogger` to have eeror code logs into the error list like the `SolutionRestoreJob`. 2. During install, warnings were not logged into the error list. 3. We were using wrong keys in `ErrorListTableEntry`. `StandardTableColumnDefinitions` keys are to be used for creating a table and `StandardTableKeyNames` keys are to be used for fetching values from an entry, as described [here](https://docs.microsoft.com/en-us/dotnet/api/microsoft.visualstudio.shell.tablecontrol.standardtablecolumndefinitions?view=visualstudiosdk-2017). 4. For non-CPS projects, the error codes displayed in the error list did not have a hyperlink. Fixing that by adding support for `StandardTableKeyNames.ErrorCodeToolTip` and `StandardTableKeyNames.HelpLink`. ## Testing/Validation Tests Added: Yes Validation done: Manual Validation.
mishra14
pushed a commit
to NuGet/NuGet.Client
that referenced
this issue
Jul 20, 2018
## Bug Fixes: NuGet/Home#6944 Regression: No ## Fix Details: This PR fixes signing logs by adding a prefix indicating the package id, version and source for the error or warning. ## Testing/Validation Tests Added: Yes Validation done: Manual validation
|
This got into Dev. Is it already in Release-4.8.0-rtm or not? I forget. |
|
This fix is not in |
PatoBeltran
pushed a commit
to NuGet/NuGet.Client
that referenced
this issue
Oct 18, 2018
Fixes: NuGet/Home#6944 Regression: No Details: This PR fixes signing logs by adding a prefix indicating the package id, version and source for the error or warning. Tests Added: Yes Validation done: Manual validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When VS tries to install a package with an invalid signature, it reports the next error in the ErrorList
The error should include:
The text was updated successfully, but these errors were encountered: