Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding package id and source prefix to signing logs #2360

Merged
merged 2 commits into from
Jul 20, 2018

Conversation

mishra14
Copy link
Contributor

Bug

Fixes: NuGet/Home#6944
Regression: No

Fix

Details: This PR fixes signing logs by adding a prefix indicating the package id, version and source for the error or warning.

Result

before -

image

WARNING: NU3018: The author primary signature found a chain building issue: A certificate chain processed, but terminated in a root certificate which is not trusted by the trust provider.
WARNING: NU3037: The author primary signature validity period has expired.
Committing restore...
Generating MSBuild file F:\validation\testsdk\obj\testsdk.csproj.nuget.g.props.
Writing lock file to disk. Path: F:\validation\testsdk\obj\project.assets.json
Restore failed in 884.94 ms for F:\validation\testsdk\testsdk.csproj.

Errors in F:\validation\testsdk\testsdk.csproj
    NU3008: The package integrity check failed.

after -

image

WARNING: NU3018: Package 'A 1.0.0' from source 'F:\validation\test-local-source': The author primary signature found a chain building issue: A certificate chain processed, but terminated in a root certificate which is not trusted by the trust provider.
WARNING: NU3037: Package 'A 1.0.0' from source 'F:\validation\test-local-source': The author primary signature validity period has expired.
Committing restore...
Generating MSBuild file C:\Users\anmishr\Source\Repos\ConsoleApp175\ConsoleApp175\obj\ConsoleApp175.csproj.nuget.g.props.
Writing lock file to disk. Path: C:\Users\anmishr\Source\Repos\ConsoleApp175\ConsoleApp175\obj\project.assets.json
Restore failed in 545.51 ms for C:\Users\anmishr\Source\Repos\ConsoleApp175\ConsoleApp175\ConsoleApp175.csproj.

Errors in C:\Users\anmishr\Source\Repos\ConsoleApp175\ConsoleApp175\ConsoleApp175.csproj
    NU3008: Package 'A 1.0.0' from source 'F:\validation\test-local-source': The package integrity check failed.

Testing/Validation

Tests Added: Yes
Validation done: Manual validation

@mishra14
Copy link
Contributor Author

This is a followup PR to #2332. After discusssing with @anangaur, @rrelyea and @dtivel, we decided to have a single prefix strategy for all signing logs.

@mishra14 mishra14 merged commit 9e7b092 into dev Jul 20, 2018
@mishra14 mishra14 deleted the dev-anmishr-signinglogswithprefix branch July 20, 2018 18:48
PatoBeltran pushed a commit that referenced this pull request Oct 18, 2018
Fixes: NuGet/Home#6944
Regression: No

Details: This PR fixes signing logs by adding a prefix indicating the package id, version and source for the error or warning.

Tests Added: Yes
Validation done:  Manual validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Package Integrity check failed." should have package ID in message (and error code)
3 participants