Implemented nuget.exe add and nuget.exe init commands #14

deepakaravindr · 2015-10-08T20:46:09Z

Both nuget.exe add and nuget.exe init follows the new v3 model to only copy the nupkg, extract the nuspec and create a SHA512 of the nupkg file at the destination. With a provision to expand the packages using '-Expand' switch

nuget.exe add: NuGet/Home#1421
Adds a given package to the specified source if it is a file source. http sources are not supported.

nuget.exe init: NuGet/Home#1423
Adds all the packages from a given feed to the specified destination feed if it is a file source feed. http feeds are not supported.

Following are pending and/or not covered in this change.

nuget.exe init only takes a folder of nupkgs as the source. Should this be upgraded to support every v2 folder source and probably v3 folder sources as well?
nuget.exe init could parallelize package additions.
Need more tests for the new '-Expand' switch. Also, need to verify and update the messages for the -Expand switch as needed.
Marker file for nuget.exe add and init: nuget.exe add and init should add a marker file to feed root Home#1456
Concurrency for "multiple exes" on other platforms: NuGet.Xplat - init and add commands Home#1455
With the latest design, Updating nuget clients may not be necessary anymore. We should close Update NuGet VS Client to honor the offline feed settings Home#1425 and Update nuget.exe to honor the offline feed Home#1424 as Won't Fix.
Update documentation on docs.nuget.org

@yishaigalatzer @MeniZalzman @emgarten

yishaigalatzer · 2015-10-08T22:36:08Z

It should take any existing folder source
Lets skip the parallelization for now
Add the tests
Skip nuget.exe add and init should add a marker file to feed root Home#1456
Concurrency is important, but can be done in a follow up PR
Closed the items
Create a doc PR

deepakaravindr · 2015-10-14T03:06:26Z

It takes any existing folder source. V2 and V3. Added tests. Manually tested.
OK
Added tests for -Expand switch. Manually tested
OK
OK
OK
Will do

emgarten · 2015-10-14T17:57:09Z

src/NuGet.Clients/NuGet.CommandLine/NuGetCommand.resx

@@ -5245,4 +5245,41 @@ nuget update -Self</value>
  <data name="CommandMSBuildVersion" xml:space="preserve">
    <value>Specifies the version of MSBuild to be used with this command. Supported values are 4, 12, 14. By default the MSBuild in your path is picked, otherwise it defaults to the highest installed version of MSBuild.</value>
  </data>
+  <data name="AddCommandDescription" xml:space="preserve">
+    <value>Adds a given package to the specified source if it is a file source. http sources are not supported.</value>


This doesn't really describe what the command is for

+1, we need to explain the offline feed concept here

Discussed with @yishaigalatzer and updated the command description both for add and init. Check it out in the next iteration.

emgarten · 2015-10-14T18:07:02Z

MeniZalzman · 2015-10-14T18:32:55Z

src/NuGet.Clients/NuGet.CommandLine/Commands/AddCommand.cs

+    public class AddCommand : Command
+    {
+        [Option(typeof(NuGetCommand), "AddCommandSourceDescription", AltName = "src")]
+        public string Source { get; set; }


Please check if we have a way to declare mandatory parameters

No. We do not have a way today to declare mandatory parameters.

MeniZalzman · 2015-10-14T22:56:26Z

… This will be used by nuget.exe add and nuget.exe init

user-defined offline feed as controlled by settings.

mandatory source and destination feed for add and init respectively. Need to fix tests

and destination feed for nuget.exe init mandatory.

and nuget.exe init using an -Expand switch. Need to add tests

…found. 2) Added more tests for nuget.exe init

Verified manually that it works. Need to add tests

simplify the not exists check on the path both for add and init commands. 2) Renamed ValidatePath to ThrowIfInvalid. 3) Added tests for OfflineFeedUtility

moved the tests to NugetPackageUtilTests.cs. Also, fixed the existing tests to use the new signature for InstallFromSourceAsync

deepakaravindr · 2015-10-15T23:22:43Z

Merged with

3004649,

5eefae0
and
5272f06

# This is the 1st commit message: Read unix executable plugins # This is the commit message #2: Add tests # This is the commit message #3: Use GetUnixFileMode # This is the commit message #4: Cleanup testing # This is the commit message #5: Add NUGET_PLUGIN_PATHS # This is the commit message #6: use empty body constructor # This is the commit message #7: NuGetPluginPaths Env variable used by dotnet tools only # This is the commit message #8: Plugins path env # This is the commit message #9: fix tests # This is the commit message #10: fix linux bash call # This is the commit message #11: remove some apis # This is the commit message #12: cleanup # This is the commit message #13: cleanup # This is the commit message #14: cleanup # This is the commit message #15: Use GetUnixFileMode # This is the commit message #16: Cleanup testing # This is the commit message #17: remove some apis # This is the commit message #18: stub # This is the commit message #19: Add test # This is the commit message #20: cleanup

# This is the 1st commit message: Read unix executable plugins # This is the commit message #2: Add tests # This is the commit message #3: Use GetUnixFileMode # This is the commit message #4: Cleanup testing # This is the commit message #5: Add NUGET_PLUGIN_PATHS # This is the commit message #6: use empty body constructor # This is the commit message #7: NuGetPluginPaths Env variable used by dotnet tools only # This is the commit message #8: Plugins path env # This is the commit message #9: fix tests # This is the commit message #10: fix linux bash call # This is the commit message #11: remove some apis # This is the commit message #12: cleanup # This is the commit message #13: cleanup # This is the commit message #14: cleanup # This is the commit message #15: Use GetUnixFileMode # This is the commit message #16: Cleanup testing # This is the commit message #17: remove some apis # This is the commit message #18: stub # This is the commit message #19: Add test # This is the commit message #20: cleanup # This is the commit message #21: cleanup # This is the commit message #22: cleanup # This is the commit message #23: oops # This is the commit message #24: Clean up # This is the commit message #25: undo

# This is the 1st commit message: Read unix executable plugins # This is the commit message #2: Add tests # This is the commit message #3: Use GetUnixFileMode # This is the commit message #4: Cleanup testing # This is the commit message #5: Add NUGET_PLUGIN_PATHS # This is the commit message #6: use empty body constructor # This is the commit message #7: NuGetPluginPaths Env variable used by dotnet tools only # This is the commit message #8: Plugins path env # This is the commit message #9: fix tests # This is the commit message #10: fix linux bash call # This is the commit message #11: remove some apis # This is the commit message #12: cleanup # This is the commit message #13: cleanup # This is the commit message #14: cleanup # This is the commit message #15: Use GetUnixFileMode # This is the commit message #16: Cleanup testing # This is the commit message #17: remove some apis # This is the commit message #18: stub # This is the commit message #19: Add test # This is the commit message #20: cleanup

# This is the 1st commit message: Read unix executable plugins # This is the commit message #2: Add tests # This is the commit message #3: Use GetUnixFileMode # This is the commit message #4: Cleanup testing # This is the commit message #5: Add NUGET_PLUGIN_PATHS # This is the commit message #6: use empty body constructor # This is the commit message #7: NuGetPluginPaths Env variable used by dotnet tools only # This is the commit message #8: Plugins path env # This is the commit message #9: fix tests # This is the commit message #10: fix linux bash call # This is the commit message #11: remove some apis # This is the commit message #12: cleanup # This is the commit message #13: cleanup # This is the commit message #14: cleanup # This is the commit message #15: Use GetUnixFileMode # This is the commit message #16: Cleanup testing # This is the commit message #17: remove some apis # This is the commit message #18: stub # This is the commit message #19: Add test # This is the commit message #20: cleanup # This is the commit message #21: cleanup # This is the commit message #22: cleanup # This is the commit message #23: oops # This is the commit message #24: Clean up # This is the commit message #25: undo

# This is the 1st commit message: Read unix executable plugins # This is the commit message #2: Add tests # This is the commit message #3: Use GetUnixFileMode # This is the commit message #4: Cleanup testing # This is the commit message #5: Add NUGET_PLUGIN_PATHS # This is the commit message #6: use empty body constructor # This is the commit message #7: NuGetPluginPaths Env variable used by dotnet tools only # This is the commit message #8: Plugins path env # This is the commit message #9: fix tests # This is the commit message #10: fix linux bash call # This is the commit message #11: remove some apis # This is the commit message #12: cleanup # This is the commit message #13: cleanup # This is the commit message #14: cleanup # This is the commit message #15: Use GetUnixFileMode # This is the commit message #16: Cleanup testing # This is the commit message #17: remove some apis # This is the commit message #18: stub # This is the commit message #19: Add test # This is the commit message #20: cleanup # This is the commit message #21: cleanup # This is the commit message #22: cleanup # This is the commit message #23: oops # This is the commit message #24: Clean up # This is the commit message #25: undo # This is the commit message #26: cleanup # This is the commit message #27: cleanup # This is the commit message #28: # This is a combination of 20 commits. # This is the 1st commit message: Read unix executable plugins # This is the commit message #2: Add tests # This is the commit message #3: Use GetUnixFileMode # This is the commit message #4: Cleanup testing # This is the commit message #5: Add NUGET_PLUGIN_PATHS # This is the commit message #6: use empty body constructor # This is the commit message #7: NuGetPluginPaths Env variable used by dotnet tools only # This is the commit message #8: Plugins path env # This is the commit message #9: fix tests # This is the commit message #10: fix linux bash call # This is the commit message #11: remove some apis # This is the commit message #12: cleanup # This is the commit message #13: cleanup # This is the commit message #14: cleanup # This is the commit message #15: Use GetUnixFileMode # This is the commit message #16: Cleanup testing # This is the commit message #17: remove some apis # This is the commit message #18: stub # This is the commit message #19: Add test # This is the commit message #20: cleanup

dnfclas added the cla-already-signed label Oct 8, 2015

emgarten reviewed Oct 14, 2015
View reviewed changes

MeniZalzman reviewed Oct 14, 2015
View reviewed changes

deepakaravindr added 13 commits October 15, 2015 13:51

Updated NuGetPackageUtils to be able to extract only the nuspec file.…

9872689

… This will be used by nuget.exe add and nuget.exe init

nuget.exe init and nuget.exe add with tests, that supports a

e89fc5b

user-defined offline feed as controlled by settings.

nuget.exe add and nuget.exe init which are simpler and always needs a

f5ea7ef

mandatory source and destination feed for add and init respectively. Need to fix tests

Fixed the tests and the product to make source switch for nuget.exe add

2e8af14

and destination feed for nuget.exe init mandatory.

Added support for expanding the packages in case of nuget.exe add

5538980

and nuget.exe init using an -Expand switch. Need to add tests

Fixed maxArgs for nuget.exe add and added tests for the same

545d48a

1) Made nuget.exe init create the destination directory if it is not …

84fac0d

…found. 2) Added more tests for nuget.exe init

Updated init to support both v2 style and v3 style folder sources.

81f552e

Verified manually that it works. Need to add tests

Added tests for v2-style and v3-style source folders.

b41eda6

Added tests for -Expand switch for nuget.exe add and init

39521b5

1) Added a new method ThrowIfInvalidOrNotFound to OfflineFeedUtility to

280762e

simplify the not exists check on the path both for add and init commands. 2) Renamed ValidatePath to ThrowIfInvalid. 3) Added tests for OfflineFeedUtility

Incorporated the comments on the help string messages.

85556a3

Removed NuGetPackageUtilsTests and

d6e75a7

moved the tests to NugetPackageUtilTests.cs. Also, fixed the existing tests to use the new signature for InstallFromSourceAsync

deepakaravindr force-pushed the daravind/offlinefeed branch from b77d921 to d6e75a7 Compare October 15, 2015 20:55

deepakaravindr closed this Oct 15, 2015

deepakaravindr deleted the daravind/offlinefeed branch January 7, 2016 23:12

nkolev92 added a commit that referenced this pull request Mar 30, 2022

attemp #14

2136492

TheCakeIsNaOH pushed a commit to TheCakeIsNaOH/NuGet.Client that referenced this pull request Jan 6, 2023

Merge pull request NuGet#14 from gep13/nupkg-info

a0210f0

davkean mentioned this pull request Dec 21, 2023

Create class for reading Json files in chunks #5530

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implemented nuget.exe add and nuget.exe init commands #14

Implemented nuget.exe add and nuget.exe init commands #14

deepakaravindr commented Oct 8, 2015

yishaigalatzer commented Oct 8, 2015

deepakaravindr commented Oct 14, 2015

emgarten Oct 14, 2015

MeniZalzman Oct 14, 2015

deepakaravindr Oct 14, 2015

emgarten commented Oct 14, 2015

MeniZalzman Oct 14, 2015

deepakaravindr Oct 14, 2015

MeniZalzman commented Oct 14, 2015

deepakaravindr commented Oct 15, 2015

Implemented nuget.exe add and nuget.exe init commands #14

Implemented nuget.exe add and nuget.exe init commands #14

Conversation

deepakaravindr commented Oct 8, 2015

yishaigalatzer commented Oct 8, 2015

deepakaravindr commented Oct 14, 2015

emgarten Oct 14, 2015

Choose a reason for hiding this comment

MeniZalzman Oct 14, 2015

Choose a reason for hiding this comment

deepakaravindr Oct 14, 2015

Choose a reason for hiding this comment

emgarten commented Oct 14, 2015

MeniZalzman Oct 14, 2015

Choose a reason for hiding this comment

deepakaravindr Oct 14, 2015

Choose a reason for hiding this comment

MeniZalzman commented Oct 14, 2015

deepakaravindr commented Oct 15, 2015