Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix1444 #3

Closed
wants to merge 4 commits into from
Closed

Fix1444 #3

wants to merge 4 commits into from

Conversation

zhili1208
Copy link
Contributor

fixed NuGet/Home#1444

added API for integrating other package manager

@yishaigalatzer @emgarten @deepakaravindr @feiling @danliu @MeniZalzman

emgarten
emgarten reviewed Oct 8, 2015
View reviewed changes
src/NuGet.Clients/VisualStudioAPI/IPackageManagerProvider.cs
namespace NuGet.VisualStudio
{
/// <summary>
/// Interface for integrating other package manager
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provide a longer description here, comments on public VS interfaces will become the documentation.

@emgarten
Copy link
Member

emgarten commented Oct 8, 2015

⌚

yishaigalatzer
yishaigalatzer reviewed Oct 8, 2015
View reviewed changes
src/NuGet.Clients/VisualStudioAPI/IPackageManagerProvider.cs
using System.Threading;
using System.Threading.Tasks;

namespace NuGet.VisualStudio
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated, but please change the project name and folder from VisualStudioAPI to NuGet.VisualStudio the project name should match the generated assembly

@yishaigalatzer
Copy link
Contributor

Need a test that will load multiple providers and make sure they are sorted in the right way.

⌚

@yishaigalatzer
Copy link
Contributor

Being a new NuGet API, adding the API owners
CC @Pilchie @ericstj @MeniZalzman @davidfowl

emgarten
emgarten reviewed Oct 13, 2015
View reviewed changes
src/NuGet.Clients/VisualStudio/IPackageManagerProvider.cs
/// </summary>
[ComImport]
[Guid("BCED5BF2-40FC-4D9F-BF0A-43CD4E9FF65F")]
public interface IPackageManagerProvider
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be IVsPackageManagerProvider

Our truly public VS interfaces have IVs on them.

@emgarten
Copy link
Member

:shipit:

deepakaravindr
deepakaravindr reviewed Oct 14, 2015
View reviewed changes
NuGet.Clients.sln
{1E243B39-7C61-4525-A664-3DC8589707AC}.Release|x64.ActiveCfg = Release|Any CPU
{1E243B39-7C61-4525-A664-3DC8589707AC}.Release|x64.Build.0 = Release|Any CPU
{1E243B39-7C61-4525-A664-3DC8589707AC}.Release|x86.ActiveCfg = Release|Any CPU
{1E243B39-7C61-4525-A664-3DC8589707AC}.Release|x86.Build.0 = Release|Any CPU
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please double-check these additions. I don't think they are valid

@deepakaravindr
Copy link
Contributor

:shipit: (Signed-off with comments)

@zhili1208 zhili1208 closed this Oct 14, 2015
@zhili1208 zhili1208 deleted the fix1444 branch October 19, 2015 17:38
@rohit21agrawal rohit21agrawal mentioned this pull request Mar 23, 2017
Merged
donnie-msft referenced this pull request Jun 4, 2020
@srdjanjovcic
Nuget.Client/Telemetry: Clean-up and add comments on public members. (#…
83091ac 
…3424)

Co-authored-by: Srdjan Jovcic <srdjanj@microsoft.com>
@martinrrm martinrrm mentioned this pull request Aug 18, 2022
Merged
8 tasks
Nigusu-Allehu added a commit that referenced this pull request Oct 22, 2024
@Nigusu-Allehu
# This is a combination of 20 commits.
a67e66c 
# This is the 1st commit message:

Read unix executable plugins

# This is the commit message #2:

Add tests

# This is the commit message #3:

Use GetUnixFileMode

# This is the commit message #4:

Cleanup testing

# This is the commit message #5:

Add NUGET_PLUGIN_PATHS

# This is the commit message #6:

use empty body constructor

# This is the commit message #7:

NuGetPluginPaths Env variable used by dotnet tools only

# This is the commit message #8:

Plugins path env

# This is the commit message #9:

fix tests

# This is the commit message #10:

fix linux bash call

# This is the commit message #11:

remove some apis

# This is the commit message #12:

cleanup

# This is the commit message #13:

cleanup

# This is the commit message #14:

cleanup
# This is the commit message #15:

Use GetUnixFileMode

# This is the commit message #16:

Cleanup testing

# This is the commit message #17:

remove some apis

# This is the commit message #18:

stub

# This is the commit message #19:

Add test

# This is the commit message #20:

cleanup
Nigusu-Allehu added a commit that referenced this pull request Oct 22, 2024
@Nigusu-Allehu
# This is a combination of 25 commits.
11e7376 
# This is the 1st commit message:

Read unix executable plugins

# This is the commit message #2:

Add tests

# This is the commit message #3:

Use GetUnixFileMode

# This is the commit message #4:

Cleanup testing

# This is the commit message #5:

Add NUGET_PLUGIN_PATHS

# This is the commit message #6:

use empty body constructor

# This is the commit message #7:

NuGetPluginPaths Env variable used by dotnet tools only

# This is the commit message #8:

Plugins path env

# This is the commit message #9:

fix tests

# This is the commit message #10:

fix linux bash call

# This is the commit message #11:

remove some apis

# This is the commit message #12:

cleanup

# This is the commit message #13:

cleanup

# This is the commit message #14:

cleanup
# This is the commit message #15:

Use GetUnixFileMode

# This is the commit message #16:

Cleanup testing

# This is the commit message #17:

remove some apis

# This is the commit message #18:

stub

# This is the commit message #19:

Add test

# This is the commit message #20:

cleanup
# This is the commit message #21:

cleanup

# This is the commit message #22:

cleanup

# This is the commit message #23:

oops
# This is the commit message #24:

Clean up
# This is the commit message #25:

undo
Nigusu-Allehu added a commit that referenced this pull request Oct 22, 2024
@Nigusu-Allehu
# This is a combination of 20 commits.
edc0101 
# This is the 1st commit message:

Read unix executable plugins

# This is the commit message #2:

Add tests

# This is the commit message #3:

Use GetUnixFileMode

# This is the commit message #4:

Cleanup testing

# This is the commit message #5:

Add NUGET_PLUGIN_PATHS

# This is the commit message #6:

use empty body constructor

# This is the commit message #7:

NuGetPluginPaths Env variable used by dotnet tools only

# This is the commit message #8:

Plugins path env

# This is the commit message #9:

fix tests

# This is the commit message #10:

fix linux bash call

# This is the commit message #11:

remove some apis

# This is the commit message #12:

cleanup

# This is the commit message #13:

cleanup

# This is the commit message #14:

cleanup
# This is the commit message #15:

Use GetUnixFileMode

# This is the commit message #16:

Cleanup testing

# This is the commit message #17:

remove some apis

# This is the commit message #18:

stub

# This is the commit message #19:

Add test

# This is the commit message #20:

cleanup
Nigusu-Allehu added a commit that referenced this pull request Oct 22, 2024
@Nigusu-Allehu
# This is a combination of 25 commits.
0380e40 
# This is the 1st commit message:

Read unix executable plugins

# This is the commit message #2:

Add tests

# This is the commit message #3:

Use GetUnixFileMode

# This is the commit message #4:

Cleanup testing

# This is the commit message #5:

Add NUGET_PLUGIN_PATHS

# This is the commit message #6:

use empty body constructor

# This is the commit message #7:

NuGetPluginPaths Env variable used by dotnet tools only

# This is the commit message #8:

Plugins path env

# This is the commit message #9:

fix tests

# This is the commit message #10:

fix linux bash call

# This is the commit message #11:

remove some apis

# This is the commit message #12:

cleanup

# This is the commit message #13:

cleanup

# This is the commit message #14:

cleanup
# This is the commit message #15:

Use GetUnixFileMode

# This is the commit message #16:

Cleanup testing

# This is the commit message #17:

remove some apis

# This is the commit message #18:

stub

# This is the commit message #19:

Add test

# This is the commit message #20:

cleanup
# This is the commit message #21:

cleanup

# This is the commit message #22:

cleanup

# This is the commit message #23:

oops
# This is the commit message #24:

Clean up
# This is the commit message #25:

undo
Nigusu-Allehu added a commit that referenced this pull request Oct 22, 2024
@Nigusu-Allehu
# This is a combination of 28 commits.
ae2bdf2 
# This is the 1st commit message:

Read unix executable plugins

# This is the commit message #2:

Add tests

# This is the commit message #3:

Use GetUnixFileMode

# This is the commit message #4:

Cleanup testing

# This is the commit message #5:

Add NUGET_PLUGIN_PATHS

# This is the commit message #6:

use empty body constructor

# This is the commit message #7:

NuGetPluginPaths Env variable used by dotnet tools only

# This is the commit message #8:

Plugins path env

# This is the commit message #9:

fix tests

# This is the commit message #10:

fix linux bash call

# This is the commit message #11:

remove some apis

# This is the commit message #12:

cleanup

# This is the commit message #13:

cleanup

# This is the commit message #14:

cleanup
# This is the commit message #15:

Use GetUnixFileMode

# This is the commit message #16:

Cleanup testing

# This is the commit message #17:

remove some apis

# This is the commit message #18:

stub

# This is the commit message #19:

Add test

# This is the commit message #20:

cleanup
# This is the commit message #21:

cleanup

# This is the commit message #22:

cleanup

# This is the commit message #23:

oops
# This is the commit message #24:

Clean up
# This is the commit message #25:

undo
# This is the commit message #26:

cleanup

# This is the commit message #27:

cleanup

# This is the commit message #28:

# This is a combination of 20 commits.
# This is the 1st commit message:

Read unix executable plugins

# This is the commit message #2:

Add tests

# This is the commit message #3:

Use GetUnixFileMode

# This is the commit message #4:

Cleanup testing

# This is the commit message #5:

Add NUGET_PLUGIN_PATHS

# This is the commit message #6:

use empty body constructor

# This is the commit message #7:

NuGetPluginPaths Env variable used by dotnet tools only

# This is the commit message #8:

Plugins path env

# This is the commit message #9:

fix tests

# This is the commit message #10:

fix linux bash call

# This is the commit message #11:

remove some apis

# This is the commit message #12:

cleanup

# This is the commit message #13:

cleanup

# This is the commit message #14:

cleanup
# This is the commit message #15:

Use GetUnixFileMode

# This is the commit message #16:

Cleanup testing

# This is the commit message #17:

remove some apis

# This is the commit message #18:

stub

# This is the commit message #19:

Add test

# This is the commit message #20:

cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Design and implement IPackageManagerProvider API
5 participants
@zhili1208 @emgarten @yishaigalatzer @deepakaravindr @dnfclas