Implement Blame Collector to help detect and fix hangs in test code #3741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5d2936883b359d16fd71e83b5a2cc7acf68805eb.
This reverts commit a3f3e320cfe71f3c21e7e787c4336fc2a39abd2e.
…ng""" This reverts commit a60414236d933c1807003a7c5097957ca0beb9ed.
nkolev92
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Client.Engineering#577
Regression: No
Fix
Details:
dotnet testhas an option called--blame-hangto run the tests in blame mode and collects a hang dump when a test exceeds the given timeout. As per this vstest issue, collect hang dumps is enabled on Windows, Mac, and Linux.If any test hangs, this command will collect a hang dump and a
Sequence.xmlfile which contains the execution order of tests.I added
PublishBuildArtifactsstep to theyamlfile which only runs if the testsfailed or canceledso that dump file and other test results file can be published to build artifacts for troubleshooting issues.I created an issue in the vstest repo because in this build,
CollectDumpOnTestSessionHang didn't save dump file to Artifacts when Azure DevOps pipeline job was canceled due to the Linux job timeoutTesting/Validation
Tests Added: No
Reason for not adding tests:
Validation: