Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving blame collector functionality of TestPlatform #2380

Closed
24 tasks done
pavelhorak opened this issue Apr 1, 2020 · 1 comment · Fixed by #2558
Closed
24 tasks done

Improving blame collector functionality of TestPlatform #2380

pavelhorak opened this issue Apr 1, 2020 · 1 comment · Fixed by #2558
Assignees

Comments

@pavelhorak
Copy link
Member

pavelhorak commented Apr 1, 2020

  • The blame collector should support collecting dumps on all platforms:
    MacOS
    Windows
    Linux

  • The blame collector should support killing the testhost on a hang on all platforms.

  • collect crash dump on Windows (without procdump) - waiting for Task exceptions to work - Fix stack overflow createdump triggering on Windows dotnet/runtime#40869 ready for intergration hopefully

  • collect hang dumps on OSX without sudo - waiting for preview 8

  • revert: attach sequence even when all tests finished

  • ^^^ print message to console, when all tests finish, because otherwise AzDO would try to parse the sequence file

  • collect hang dumps on linux

  • collect hang dump on Windows

  • collect hang dumps on OSX with sudo

  • collect crash dumps on linux

  • collect crash dump on Windows (with procdump)

  • collect crash dumps on OSX

  • collect dumps from child processes Collect crash dumps using diagnostics netclient #2498

  • report the test that was hanging not the one that ran last Report the test that was hanging, not the last that ran when using Blame #2499

  • add --blame syntax to dotnet test+dll and dotnet vstest

  • ensure we are able to run on net5.1 and newer -> (!string.IsNullOrWhiteSpace(targetFramework) && !targetFramework.Contains("v5.0"))

  • attach sequence even when all tests finished

  • add dump type for hang with netclient helper

  • add dump type with netclient crash dumper

- [ ] report tests affected by testhost crash as failed, instead of NotRun #2506

  • add parameter to specify custom location for dump creation and skip adding it to attachments - added VSTEST_DUMP_PATH

  • report the correct test when crashing - feedback ticket - we don't actually know the test that crashed for sure, and we cannot know because any background thread can kill testhost, but I improved the message to bring attention to the callstack, and to point out that the failing test is the one that run, but not necessarilly the one that caused the issue.

  • validate crash dump on Windows (without procdump) - waiting for Task exceptions to work - Fix stack overflow createdump triggering on Windows dotnet/runtime#40869 ready for intergration hopefully, waiting for this to be merged to have the dumps work correctly again, because now it won't dump testhost. [master] Update dependencies from dotnet/sdk dotnet/installer#8129 - 🙌 works with 5.0.100-rc.1.20420.2

  • validate hang dumps on OSX without sudo - does not work on p8 but works on rc1

  • port changes to .net5.0?

  • run blame pipeline on rc1

AB#1091251

@nohwnd
Copy link
Member

nohwnd commented Sep 2, 2020

Inserted into RC1 should be done for now. 🎊🥳🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants