Crash dumps via net client #2532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @nohwnd! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 3 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
cvpoienaru
approved these changes
Aug 20, 2020
| string value; | ||
| string unit; | ||
|
|
||
| if (this.inactivityTimespan.TotalSeconds <= 90) |
There was a problem hiding this comment.
nit: Maybe use a constant instead of "90" ?
|
|
||
| if (!this.uploadDumpFiles) | ||
| { | ||
| this.logger.LogWarning(this.context.SessionDataCollectionContext, $"VSTEST_DUMP_PATH is specified. Dump files will be saved in: {dumpPath}, and won't be added to attachments."); |
There was a problem hiding this comment.
nit: Should we use a resource string instead ?
There was a problem hiding this comment.
This will be seen by virtually no-one outside of Helix infra. But in general yes.
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Few more fixes, like the process tree and not suspending processes on mac and linux so we don't hang the hang dumping.
Related issue
Related #2380