Improve installation of .NET for building NuGet.Client repository #5134
Conversation
jeffkl
force-pushed
the
dev-jeffkl-dotnet-cli
branch
from
b2b7209 to
c70298b
Compare
jeffkl
force-pushed
the
dev-jeffkl-dotnet-cli
branch
from
c70298b to
aacedbf
Compare
| @@ -0,0 +1,5 @@ | |||
| # Each line represents arguments for the .NET SDK installer script (https://learn.microsoft.com/dotnet/core/tools/dotnet-install-script) | |||
| -Channel 7.0 | |||
| -Channel 6.0 -Runtime dotnet | |||
There was a problem hiding this comment.
What's the purpose of the -runtime dotnet on the line, but not others?
We've had contributors using some IBM mainframe contribute to NuGet, but it uses the mono runtime (not Mono Project, that implements .NET Framework, but the mono runtime of the .NET Core App runtime). By specifying -runtime dotnet, is it going to cause problems for customers on platforms that the dotnet runtime doesn't have binaries for?
There was a problem hiding this comment.
I found that some of our tests need the .NET 6 runtime but don't need the full SDK. I've experimented a little and hope to trim this down as soon as all of our tests target .NET 7 or .NET 8.
| @@ -26,7 +26,8 @@ Param ( | |||
| [switch]$CleanCache, | |||
There was a problem hiding this comment.
Any chance while you're at it, you could move the strong name key disable code out of build.ps1 and into configure.ps1? It's something that needs to be configured once per machine, not every build.
There was a problem hiding this comment.
Yeah I wasn't sure if it needed to be configured unless you want to debug our VSIX? Or is it safe to disable it on everyone's machine that runs this script?
There was a problem hiding this comment.
I think it needs to be disabled not only to run the VSIX, but also to run the .NET Framework restore task, the non-ilmerged nuget.exe (maybe even the ilmerged nuget.exe). I'm not sure about running tests. Maybe it's needed for that too. Basically, I think strong name validation for our 2 keys should be disabled for everyone running the script on Windows.
| # Each line represents arguments for the .NET SDK installer script (https://learn.microsoft.com/dotnet/core/tools/dotnet-install-script) | ||
| -Channel 7.0 | ||
| -Channel 6.0 -Runtime dotnet | ||
| -Channel 5.0 |
There was a problem hiding this comment.
Why do we need the 5.0 and 3.1 SDKs?
Aren't the runtimes sufficient for this?
We'll always build with the latest installed SDK anyways.
Bug
Fixes: https://github.com/NuGet/Client.Engineering/issues/2250
Regression? Last working version:
Description
This makes it so that our hosted build always uses the .NET SDKs and runtimes we need for our build to work.
configure.shso non-Windows machines can initialize the .NET SDKs like WindowsDOTNET_ROOT,DOTNET_MULTILEVEL_LOOKUP=0, and adddotnetto thePATHfor that command windowCLIBRANCHFORTESTINGto use different versions for testing something else or having a different configuration for different pipelinesPR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation