Improve installation of .NET for building NuGet.Client repository #5134
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| # Each line represents arguments for the .NET SDK installer script (https://learn.microsoft.com/dotnet/core/tools/dotnet-install-script) | ||
| -Channel 7.0 | ||
| -Channel 6.0 -Runtime dotnet | ||
| -Channel 5.0 | ||
|
There was a problem hiding this comment. Why do we need the 5.0 and 3.1 SDKs? We'll always build with the latest installed SDK anyways. |
||
| -Channel 3.1 | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,14 @@ | ||
| @echo off | ||
| powershell.exe -NoProfile -ExecutionPolicy RemoteSigned -Command "%~dpn0.ps1" -SkipDotnetInfo %* | ||
| IF ERRORLEVEL 1 ( | ||
| EXIT /B %ERRORLEVEL% | ||
| ) | ||
|
|
||
| SET "DOTNET_ROOT=%~dp0cli" | ||
| SET DOTNET_MULTILEVEL_LOOKUP=0 | ||
| SET "PATH=%~dp0cli;%PATH%" | ||
| dotnet --info | ||
| IF ERRORLEVEL 1 ( | ||
| ECHO "dotnet --info exited with non-zero exit code" 1>&2 | ||
| EXIT /B 1 | ||
| ) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| CLI_DIR="$(pwd)/cli" | ||
|
|
||
| # Download the CLI install script to cli | ||
| echo "Installing .NET SDKs..." | ||
| mkdir -p $CLI_DIR | ||
| curl -o $CLI_DIR/dotnet-install.sh -L https://dot.net/v1/dotnet-install.sh --silent | ||
| if (( $? )); then | ||
| echo "Could not download 'dotnet-install.sh' script. Please check your network and try again!" | ||
| return 1 | ||
| fi | ||
|
|
||
| # Run install.sh for cli | ||
| chmod +x $CLI_DIR/dotnet-install.sh | ||
|
|
||
| # If the DOTNET_SDK_VERSIONS environment variable is set, use its value instead of the ones in DotNetSdkVersions.txt | ||
| if [ "$DOTNET_SDK_VERSIONS" != "" ]; then | ||
| echo "Using environment variable DOTNET_SDK_VERSIONS instead of DotNetSdkVersions.txt. Value: '$DOTNET_SDK_VERSIONS'" | ||
| IFS=';' read -ra array <<< "$DOTNET_SDK_VERSIONS" | ||
| for CliArgs in "${array[@]}"; | ||
| do | ||
| echo "'cli/dotnet-install.sh -InstallDir $CLI_DIR -NoPath $CliArgs'" | ||
|
|
||
| cli/dotnet-install.sh -InstallDir $CLI_DIR -NoPath $CliArgs | ||
| if (( $? )); then | ||
| echo "The .NET install failed!" | ||
| return 1 | ||
| fi | ||
| done | ||
| else | ||
| # Get CLI Branches for testing | ||
| cat build/DotNetSdkVersions.txt | while IFS=$'\r' read -r CliArgs || [[ -n $line ]]; | ||
| do | ||
| if [ "${CliArgs:0:1}" != "#" ] || [ "$CliArgs" == "" ]; then | ||
| echo "'cli/dotnet-install.sh -InstallDir $CLI_DIR -NoPath $CliArgs'" | ||
|
|
||
| cli/dotnet-install.sh -InstallDir $CLI_DIR -NoPath $CliArgs | ||
| if (( $? )); then | ||
| echo "The .NET install failed!" | ||
| return 1 | ||
| fi | ||
| fi | ||
| done | ||
| fi | ||
|
|
||
| export DOTNET_ROOT="$CLI_DIR" | ||
| export DOTNET_MULTILEVEL_LOOKUP="0" | ||
| export "PATH=$CLI_DIR:$PATH" | ||
|
|
||
| if [ "$CI" == "true" ]; then | ||
| echo "##vso[task.setvariable variable=DOTNET_ROOT;isOutput=false;issecret=false;]$CLI_DIR" | ||
| echo "##vso[task.setvariable variable=DOTNET_MULTILEVEL_LOOKUP;isOutput=false;issecret=false;]0" | ||
| echo "##vso[task.prependpath]$CLI_DIR" | ||
| fi | ||
|
|
||
| # Display .NET CLI info | ||
| dotnet --info | ||
| if [ $? -ne 0 ]; then | ||
| echo "dotnet is not available on the PATH!" | ||
| return 1 | ||
| fi | ||
|
|
||
| echo "==================================================================" | ||
|
|
||
| echo "Initializing submodules..." | ||
| git submodule init | ||
| git submodule update | ||
|
|
||
| echo "Restoring bootstrap packages..." | ||
| dotnet msbuild build/bootstrap.proj /Target:Restore | ||
| if [ $? -ne 0 ]; then | ||
| echo "Bootstrap failed!!" | ||
| return 1 | ||
| fi | ||
|
|
||
| echo "Restoring NuGet packages..." | ||
| dotnet msbuild build/build.proj /Target:Restore "/ConsoleLoggerParameters:Verbosity=Minimal;Summary;ForceNoAlign" /MaxCPUCount /NodeReuse:false | ||
| if [ $? -ne 0 ]; then | ||
| echo "Restore packages failed!!" | ||
| return 1 | ||
| fi |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,4 @@ | ||
| steps: | ||
| - task: PowerShell@2 | ||
| displayName: "Print Environment Variables" | ||
| inputs: | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose of the
-runtime dotneton the line, but not others?We've had contributors using some IBM mainframe contribute to NuGet, but it uses the mono runtime (not Mono Project, that implements .NET Framework, but the mono runtime of the .NET Core App runtime). By specifying
-runtime dotnet, is it going to cause problems for customers on platforms that the dotnet runtime doesn't have binaries for?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found that some of our tests need the .NET 6 runtime but don't need the full SDK. I've experimented a little and hope to trim this down as soon as all of our tests target .NET 7 or .NET 8.