Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use Microsoft.VisualStudioEng.MicroBuild.Core package in source-build #5175

Closed
wants to merge 1 commit into from

Conversation

NikolaMilosavljevic
Copy link
Contributor

Bug

Fixes: NuGet/Home#12603

Regression? No

Description

Microsoft.VisualStudioEng.MicroBuild.Core is not consumed in .NET source-build. This change removes it from global package reference, in this scenario.

@NikolaMilosavljevic NikolaMilosavljevic requested a review from a team as a code owner May 19, 2023 17:14
@ghost ghost added the Community PRs created by someone not in the NuGet team label May 19, 2023
@NikolaMilosavljevic
Copy link
Contributor Author

NikolaMilosavljevic commented May 19, 2023

@MichaelSimons @mthalman

Do we need a source-build patch?

@MichaelSimons
Copy link
Contributor

Do we need a source-build patch?

I think a patch would be good to ensure we don't ship Preview 5 with an additional prebuilt.

@NikolaMilosavljevic
Copy link
Contributor Author

Closing in favor of #5178

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community PRs created by someone not in the NuGet team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New prebuilt package in .NET source-build: microsoft.visualstudioeng.microbuild.core.1.0.0.nupkg
4 participants