Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only allow certain packages in source build #5178

Merged
merged 4 commits into from
May 24, 2023
Merged

Conversation

zivkan
Copy link
Member

@zivkan zivkan commented May 20, 2023

Bug

Fixes: NuGet/Home#12604
Fixes: NuGet/Home#12603

Regression? yes Last working version: before #5164

Description

  • Add '$(DotNetBuildFromSource)' != 'true' conditions on two packages
  • Add target that runs after restore that validates package references in source build are on allow list, to hopefully prevent something like this happening again.

PR Checklist

  • PR has a meaningful title

  • PR has a linked issue.

  • Described changes

  • Tests

    • Automated tests added
    • OR
    • Test exception
    • OR
    • N/A
  • Documentation

    • Documentation PR or issue filled
    • OR
    • N/A

@zivkan zivkan requested a review from a team as a code owner May 20, 2023 05:43
@zivkan
Copy link
Member Author

zivkan commented May 20, 2023

cc @NikolaMilosavljevic

@kartheekp-ms
Copy link
Contributor

I think @NikolaMilosavljevic can close #5175 PR in favor of this one, correct?

@NikolaMilosavljevic
Copy link
Contributor

I think @NikolaMilosavljevic can close #5175 PR in favor of this one, correct?

Yes - closing it now. Thank you!

@zivkan zivkan merged commit 8993787 into dev May 24, 2023
@zivkan zivkan deleted the dev-zivkan-sourcebuild branch May 24, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants