Deprecate http usage: nuget list promote warning to error for http sources
#5698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkolev92
reviewed
Mar 19, 2024
| @@ -1155,40 +1170,38 @@ public void ListCommand_WhenListWithHttpSourceAndAllowInsecureConnections_WarnsC | |||
| server.Start(); | |||
|
|
|||
| // create the config file | |||
| Util.CreateFile(packageDirectory, "nuget.config", $@" | |||
There was a problem hiding this comment.
You did a really thorough job improving the tests, great job!
nkolev92
approved these changes
Mar 19, 2024
Nigusu-Allehu
added a commit
that referenced
this pull request
Apr 3, 2024
Nigusu-Allehu
added a commit
that referenced
this pull request
May 22, 2024
Nigusu-Allehu
added a commit
that referenced
this pull request
May 22, 2024
Nigusu-Allehu
added a commit
that referenced
this pull request
Jun 17, 2024
aortiz-msft
pushed a commit
that referenced
this pull request
Jun 18, 2024
* Deprecate http usage: `nuget search` promote warning to error for http sources (#5693) * Deprecate http usage: `nuget list` promote warning to error for http sources (#5698) * Deprecate http usage: `nuget push` promote warning to error for http sources (#5705) * Deprecate http usage: `delete` operations, promote warning to error for http sources (#5703) * Add `allowinsecureconnections` option (#5742) * remove integration test for now (#5758) * Deprecate http: Promote from warning to error in VS Options NuGet Package Manager (#5732) * Deprecate http usage: `source` commands, promote warning to error for http sources (#5702) * Deprecate http usage: `restore` scenarios promote warning to error for http sources (#5731) * use `--allow-insecure-connections` for dotnet nuget add command (#5853) * tests * clean up * clean up * white space * tests * comment
Nigusu-Allehu
added a commit
that referenced
this pull request
Jul 2, 2024
Nigusu-Allehu
added a commit
that referenced
this pull request
Jul 2, 2024
Nigusu-Allehu
added a commit
that referenced
this pull request
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#13323
Regression? Last working version:
Description
This PR introduces changes to replace the current warning mechanism with an error message whenever an HTTP source is utilized. This modification aims to enhance security and encourage best practices by strictly enforcing the use of HTTPS over HTTP for source connections.
Example
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation