Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate http usage: delete operations, promote warning to error for http sources #5703

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

Nigusu-Allehu
Copy link
Contributor

@Nigusu-Allehu Nigusu-Allehu commented Mar 21, 2024

Bug

Fixes: NuGet/Home#13341

Regression? Last working version:

Description

Show an error when the delete operation is used with an http source

PR Checklist

  • PR has a meaningful title

  • PR has a linked issue.

  • Described changes

  • Tests

    • Automated tests added
    • OR
    • Test exception
    • OR
    • N/A
  • Documentation

    • Documentation PR or issue filled
    • OR
    • N/A

@Nigusu-Allehu Nigusu-Allehu requested a review from a team as a code owner March 21, 2024 22:03
@Nigusu-Allehu Nigusu-Allehu self-assigned this Mar 21, 2024
@dotnet-policy-service dotnet-policy-service bot added the Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed label Apr 1, 2024
@dotnet-policy-service dotnet-policy-service bot removed the Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed label Apr 2, 2024
@Nigusu-Allehu Nigusu-Allehu force-pushed the dev-feature-http-error branch from 18162b4 to faf0a89 Compare April 3, 2024 20:15
@Nigusu-Allehu Nigusu-Allehu force-pushed the dev-nyenework-http-error-delete branch from 6b6f7c9 to 843e9f5 Compare April 3, 2024 20:21
@Nigusu-Allehu Nigusu-Allehu requested a review from nkolev92 April 3, 2024 20:27
@dotnet-policy-service dotnet-policy-service bot added the Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed label Apr 11, 2024
@Nigusu-Allehu
Copy link
Contributor Author

@NuGet/nuget-client any suggestions?

@dotnet-policy-service dotnet-policy-service bot removed the Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed label Apr 15, 2024
@Nigusu-Allehu Nigusu-Allehu merged commit 2e060e4 into dev-feature-http-error Apr 16, 2024
13 of 16 checks passed
@Nigusu-Allehu Nigusu-Allehu deleted the dev-nyenework-http-error-delete branch April 16, 2024 14:34
Nigusu-Allehu added a commit that referenced this pull request May 22, 2024
Nigusu-Allehu added a commit that referenced this pull request May 22, 2024
Nigusu-Allehu added a commit that referenced this pull request May 22, 2024
Nigusu-Allehu added a commit that referenced this pull request May 22, 2024
Nigusu-Allehu added a commit that referenced this pull request May 23, 2024
Nigusu-Allehu added a commit that referenced this pull request Jun 17, 2024
aortiz-msft pushed a commit that referenced this pull request Jun 18, 2024
* Deprecate http usage: `nuget search` promote warning to error for http sources (#5693)

* Deprecate http usage: `nuget list` promote warning to error for http sources (#5698)

* Deprecate http usage: `nuget push` promote warning to error for http sources (#5705)

* Deprecate http usage: `delete` operations, promote warning to error for http sources (#5703)

* Add `allowinsecureconnections` option (#5742)

* remove integration test for now (#5758)

* Deprecate http: Promote from warning to error in VS Options NuGet Package Manager (#5732)

* Deprecate http usage: `source` commands, promote warning to error for http sources (#5702)

* Deprecate http usage: `restore` scenarios promote warning to error for http sources (#5731)

* use `--allow-insecure-connections` for dotnet nuget add command (#5853)

* tests

* clean up

* clean up

* white space

* tests

* comment
Nigusu-Allehu added a commit that referenced this pull request Jul 2, 2024
Nigusu-Allehu added a commit that referenced this pull request Jul 2, 2024
Nigusu-Allehu added a commit that referenced this pull request Jul 2, 2024
Nigusu-Allehu added a commit that referenced this pull request Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants