Fix release-6.6.x after recent change #6156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffkl
added
the
Engineering
|
FYI @martinrrm my recent change broke the official build for |
jgonz120
approved these changes
Nov 21, 2024
martinrrm
approved these changes
Nov 21, 2024
donnie-msft
approved these changes
Nov 21, 2024
Nigusu-Allehu
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes:
Description
When disabling tests for the official build of
release-6.6.xin #6155, I accidentally broke it because some of the templates didn't have the parameters when I thought they did. This change puts the parameters in place to get the build working again. This time I pushed to Trusted so I could actually run the build ahead of time to verify.https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=10596490
PR Checklist