Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop running tests in Official Build (release-6.6.x) #6155

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

jeffkl
Copy link
Contributor

@jeffkl jeffkl commented Nov 19, 2024

Bug

Fixes:

Description

The official build for release-6.6.x is failing because of a change in MSBuild. We stopped running tests in official builds in #6035 so this is just to keep this release branch in sync with the main branch

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • Added tests
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.

@jeffkl jeffkl added the Engineering Changes related to the build infrastructure of the repo and that do not change product code label Nov 19, 2024
@jeffkl jeffkl self-assigned this Nov 19, 2024
@jeffkl jeffkl requested a review from a team as a code owner November 19, 2024 21:50
@jeffkl jeffkl requested a review from martinrrm November 19, 2024 21:50
@jeffkl
Copy link
Contributor Author

jeffkl commented Nov 19, 2024

FYI @martinrrm I noticed this failure in the Hotseat dashboard and figured I'd fix it since you're swamped with actual hotseat work

@jeffkl jeffkl merged commit 2fcc929 into release-6.6.x Nov 21, 2024
1 of 2 checks passed
@jeffkl jeffkl deleted the dev-jeffkl-no-tests-release-6.6 branch November 21, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Changes related to the build infrastructure of the repo and that do not change product code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants