This repository has been archived by the owner on Jul 30, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 21
Update gallery certificate info in ProcessSignature job #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelverhagen
requested review from
agr,
loic-sharma,
xavierdecoster,
shishirx34,
zivkan,
ryuyu,
dtivel,
chenriksson,
cristinamanum,
skofman1,
scottbommarito and
zhhyu
July 27, 2018 00:53
loic-sharma
approved these changes
Jul 27, 2018
joelverhagen
force-pushed
the
jver-certinfo
branch
from
July 30, 2018 15:23
f4e9bda
to
471c5f8
Compare
joelverhagen
added a commit
that referenced
this pull request
Jul 30, 2018
joelverhagen
force-pushed
the
jver-certinfo
branch
from
July 30, 2018 15:25
471c5f8
to
ff2914b
Compare
joelverhagen
added a commit
that referenced
this pull request
Jul 30, 2018
joelverhagen
force-pushed
the
jver-certinfo
branch
from
July 30, 2018 16:08
ff2914b
to
8748c13
Compare
joelverhagen
added a commit
that referenced
this pull request
Jul 30, 2018
joelverhagen
force-pushed
the
jver-certinfo
branch
from
July 30, 2018 19:22
8748c13
to
c7e7a65
Compare
joelverhagen
added a commit
that referenced
this pull request
Jul 30, 2018
joelverhagen
force-pushed
the
jver-certinfo
branch
from
July 31, 2018 16:30
c7e7a65
to
53aa286
Compare
joelverhagen
added a commit
that referenced
this pull request
Jul 31, 2018
joelverhagen
force-pushed
the
jver-certinfo
branch
from
July 31, 2018 21:32
53aa286
to
541f507
Compare
joelverhagen
added a commit
that referenced
this pull request
Jul 31, 2018
dtivel
approved these changes
Jul 31, 2018
|
||
private string NoLongerThanOrNull(string input) | ||
{ | ||
if (input == null || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove input == null ||
--- it's covered by the subsequent expression.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, right.
joelverhagen
force-pushed
the
jver-certinfo
branch
from
July 31, 2018 23:01
541f507
to
e4131d3
Compare
joelverhagen
added a commit
that referenced
this pull request
Sep 27, 2019
joelverhagen
added a commit
that referenced
this pull request
Oct 26, 2020
joelverhagen
added a commit
that referenced
this pull request
Oct 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on NuGet/NuGetGallery#6183