This repository has been archived by the owner on Mar 16, 2021. It is now read-only.
Tweaked Search Service's Successful Request Telemetry Logic #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skofman1
reviewed
May 23, 2017
| @@ -5,6 +5,12 @@ | |||
| <Add Type="Microsoft.ApplicationInsights.WindowsServer.TelemetryChannel.AdaptiveSamplingTelemetryProcessor, Microsoft.AI.ServerTelemetryChannel"> | |||
| <MaxTelemetryItemsPerSecond>5</MaxTelemetryItemsPerSecond> | |||
| </Add> | |||
| <Add Type="NuGet.Services.Logging.TelemetryResponseCodeProcessor, NuGet.Services.Logging"> | |||
There was a problem hiding this comment.
This file resets every time you update AI nuget package version. Can we move the changes to code?
There was a problem hiding this comment.
Ah, I didn't know that. That sounds good to me.
skofman1
approved these changes
May 23, 2017
joelverhagen
approved these changes
May 23, 2017
15 tasks
shishirx34
added a commit
that referenced
this pull request
Jun 9, 2017
* Fixed Application Insights Sampling and Duplication Issues (#183) * Removed Serilog's Request tracing * Don't sample traces and exceptions * Tweaked Search Service's Successful Request Telemetry Logic (#193) * V3 monitoring job: emit validation status of packages to blob storage (#192) * Enable blob snapshot (#177) * Add V3 monitoring deployment scripts (#196) * Fixed RoleInstance log value on Search Service (#194) * Update telemetry processors (#198) * V3 monitoring job: make RegistrationIdValidator case insensitive (#197)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Search Service marked
400and404response codes as unsuccessful requests on Application Insights, which causes lots of unwanted noise. This adds theTelemetryResponseCodeProcessorto the Search Service's Application Insights configuration to mark these responses' telemetry as successful.