Skip to content
This repository has been archived by the owner on Mar 16, 2021. It is now read-only.

Tweaked Search Service's Successful Request Telemetry Logic #193

Merged
merged 2 commits into from
May 24, 2017
Merged

Tweaked Search Service's Successful Request Telemetry Logic #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
071a91e
Add TelemetryResponseCodeProcessor to Search Service
loic-sharma May 23, 2017
53f8400
Use code to initialize TelemetryResponseCodeProcessor
loic-sharma May 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/NuGet.Services.BasicSearch/NuGet.Services.BasicSearch.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,8 +231,8 @@
<Reference Include="NuGet.Services.KeyVault, Version=2.1.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
<HintPath>..\..\packages\NuGet.Services.KeyVault.2.1.0\lib\net45\NuGet.Services.KeyVault.dll</HintPath>
</Reference>
<Reference Include="NuGet.Services.Logging, Version=2.1.1.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
<HintPath>..\..\packages\NuGet.Services.Logging.2.1.1\lib\net452\NuGet.Services.Logging.dll</HintPath>
<Reference Include="NuGet.Services.Logging, Version=2.2.1.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
<HintPath>..\..\packages\NuGet.Services.Logging.2.2.1\lib\net452\NuGet.Services.Logging.dll</HintPath>
</Reference>
<Reference Include="NuGet.Versioning, Version=4.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
<HintPath>..\..\packages\NuGet.Versioning.4.0.0\lib\net45\NuGet.Versioning.dll</HintPath>
Expand Down
17 changes: 16 additions & 1 deletion src/NuGet.Services.BasicSearch/Startup.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
using System.Threading.Tasks;
using System.Web.Cors;
using Lucene.Net.Store;
using Microsoft.ApplicationInsights.Extensibility;
using Microsoft.Extensions.Logging;
using Microsoft.Owin;
using Microsoft.Owin.Cors;
Expand All @@ -25,7 +26,6 @@
using Serilog.Events;
using SerilogWeb.Classic;
using SerilogWeb.Classic.Enrichers;
using NuGet.Services.KeyVault;

[assembly: OwinStartup("NuGet.Services.BasicSearch", typeof(NuGet.Services.BasicSearch.Startup))]

Expand All @@ -50,6 +50,21 @@ public void Configuration(IAppBuilder app, IConfigurationFactory configFactory,
// Configure
Logging.ApplicationInsights.Initialize(config.ApplicationInsightsInstrumentationKey);

// Add telemetry processors
var processorChain = TelemetryConfiguration.Active.TelemetryProcessorChainBuilder;

processorChain.Use(next =>
{
var responseCodeProcessor = new TelemetryResponseCodeProcessor(next);

responseCodeProcessor.SuccessfulResponseCodes.Add(400);
responseCodeProcessor.SuccessfulResponseCodes.Add(404);

return responseCodeProcessor;
});

processorChain.Build();

// Create telemetry sink
_searchTelemetryClient = new SearchTelemetryClient();

Expand Down
2 changes: 1 addition & 1 deletion src/NuGet.Services.BasicSearch/packages.config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
<package id="Newtonsoft.Json" version="9.0.1" targetFramework="net452" />
<package id="NuGet.Services.Configuration" version="2.1.0" targetFramework="net452" />
<package id="NuGet.Services.KeyVault" version="2.1.0" targetFramework="net452" />
<package id="NuGet.Services.Logging" version="2.1.1" targetFramework="net452" />
<package id="NuGet.Services.Logging" version="2.2.1" targetFramework="net452" />
<package id="NuGet.Versioning" version="4.0.0" targetFramework="net452" />
<package id="Owin" version="1.0" targetFramework="net452" />
<package id="Serilog" version="2.0.0" targetFramework="net452" />
Expand Down
4 changes: 2 additions & 2 deletions tests/NuGet.Services.BasicSearchTests/NuGet.Services.BasicSearchTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,8 @@
<Reference Include="NuGet.Services.KeyVault, Version=2.1.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
<HintPath>..\..\packages\NuGet.Services.KeyVault.2.1.0\lib\net45\NuGet.Services.KeyVault.dll</HintPath>
</Reference>
<Reference Include="NuGet.Services.Logging, Version=2.1.1.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
<HintPath>..\..\packages\NuGet.Services.Logging.2.1.1\lib\net452\NuGet.Services.Logging.dll</HintPath>
<Reference Include="NuGet.Services.Logging, Version=2.2.1.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
<HintPath>..\..\packages\NuGet.Services.Logging.2.2.1\lib\net452\NuGet.Services.Logging.dll</HintPath>
</Reference>
<Reference Include="Owin, Version=1.0.0.0, Culture=neutral, PublicKeyToken=f0ebd12fd5e55cc5, processorArchitecture=MSIL">
<HintPath>..\..\packages\Owin.1.0\lib\net40\Owin.dll</HintPath>
Expand Down
2 changes: 1 addition & 1 deletion tests/NuGet.Services.BasicSearchTests/packages.config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
<package id="Newtonsoft.Json" version="9.0.1" targetFramework="net452" />
<package id="NuGet.Services.Configuration" version="2.1.0" targetFramework="net452" />
<package id="NuGet.Services.KeyVault" version="2.1.0" targetFramework="net452" />
<package id="NuGet.Services.Logging" version="2.1.1" targetFramework="net452" />
<package id="NuGet.Services.Logging" version="2.2.1" targetFramework="net452" />
<package id="Owin" version="1.0" targetFramework="net452" />
<package id="Serilog" version="2.0.0" targetFramework="net452" />
<package id="Serilog.Enrichers.Environment" version="2.1.0" targetFramework="net452" />
Expand Down