elide Task.FromResult asyncs (#9997)

NuGet · Jun 22, 2024 · 53004f0 · 53004f0
1 parent a9a79ac
commit 53004f0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/NuGetGallery/Infrastructure/Lucene/SearchClientPolicies.cs b/src/NuGetGallery/Infrastructure/Lucene/SearchClientPolicies.cs
@@ -132,9 +132,9 @@ public static IAsyncPolicy<HttpResponseMessage> SearchClientFallBackCircuitBreak
                         .OrResult(r => r.StatusCode == HttpStatusCode.Forbidden)
                         .Or<Exception>()
                         .FallbackAsync(
-                                fallbackAction: async (context, cancellationToken) =>
+                                fallbackAction: (context, cancellationToken) =>
                                 {
-                                    return await Task.FromResult(new HttpResponseMessage()
+                                    return Task.FromResult(new HttpResponseMessage()
                                     {
                                         Content = new StringContent(Strings.SearchServiceIsNotAvailable),
                                         StatusCode = HttpStatusCode.ServiceUnavailable

diff --git a/tests/NuGetGallery.Facts/Services/StatusServiceFacts.cs b/tests/NuGetGallery.Facts/Services/StatusServiceFacts.cs
@@ -173,10 +173,10 @@ public CloudStorageStatusDependencyIsAvailable(IAppConfiguration config)
                         _config = config;
                     }
 
-                    public async Task<bool> IsAvailableAsync(BlobRequestOptions options, OperationContext operationContext)
+                    public Task<bool> IsAvailableAsync(BlobRequestOptions options, OperationContext operationContext)
                     {
                         AssertConfigLocationMode(_config, options);
-                        return await Task.FromResult(true);
+                        return Task.FromResult(true);
                     }
                 }
 
@@ -189,10 +189,10 @@ public CloudStorageStatusDependencyIsNotAvailable(IAppConfiguration config)
                         _config = config;
                     }
 
-                    public async Task<bool> IsAvailableAsync(BlobRequestOptions options, OperationContext operationContext)
+                    public Task<bool> IsAvailableAsync(BlobRequestOptions options, OperationContext operationContext)
                     {
                         AssertConfigLocationMode(_config, options);
-                        return await Task.FromResult(false);
+                        return Task.FromResult(false);
                     }
                 }