elide Task.FromResult asyncs #9997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdembayar
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
@SimonCropp
I see many PRs to improve code quality from you, but there's a risk that we might introduce some in the future. Ideally, if we had those analyzers turned on in our repository, it would be great. Are you using the Roslyn analyzer? Is it possible to add them into https://github.com/NuGet/NuGetGallery/blob/dev/.editorconfig ?
|
@erdembayar sorry, not using any analyzers. but i will do a pass on the .editorconfig and see if i can suggest some improvements that will help keep the code cleaner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
given these are not actual state machines, there is no dependability concerns