Pull Request #10021: Remove elmah table usage from gallery

CREDITS.txt

@@ -6,18 +6,6 @@ The .NET Foundation (http://www.dotnetfoundation.org).
 
 NuGet includes works distributed under the licenses listed below. The full text for most of the licenses listed below can be found in the LICENSE.txt file accompanying each work. The original copyright notices have been preserved within the respective files and or packages. Please refer to the specific files and/or packages for more detailed information about the authors, copyright notices, and licenses.
 
-Elmah 1.1
------ 
-Website:      http://code.google.com/p/elmah/ 
-Copyright:    Copyright (c) 2010 Atif Azis
-License:      Apache 2.0
-
-Elmah.Contrib.Mvc 1.0
-----
-Website:      http://nuget.org/List/Packages/Elmah.Contrib.Mvc
-Copyright:    Copyright (c) 2011, Fabian Vilers
-License:      Ms-PL
-
 jQuery 1.6.2
 ----
 Website:      http://jquery.com/

sign.thirdparty.props

@@ -13,7 +13,6 @@
     <ThirdPartyBinaries Include="CsvHelper.dll" />
     <ThirdPartyBinaries Include="Dapper.StrongName.dll" />
     <ThirdPartyBinaries Include="DynamicData.EFCodeFirstProvider.dll" />
-    <ThirdPartyBinaries Include="Elmah.dll" />
     <ThirdPartyBinaries Include="ICSharpCode.SharpZipLib.dll" />
     <ThirdPartyBinaries Include="Knapcode.MiniZip.dll" />
     <ThirdPartyBinaries Include="Lucene.Net.Contrib.Analyzers.dll" />

src/AccountDeleter/Configuration/GalleryConfiguration.cs

@@ -28,7 +28,6 @@ public string SiteRoot
         public string AzureStorage_Auditing_ConnectionString { get => throw new NotImplementedException(); set => throw new NotImplementedException(); }
         public string AzureStorage_UserCertificates_ConnectionString { get => throw new NotImplementedException(); set => throw new NotImplementedException(); }
         public string AzureStorage_Content_ConnectionString { get => throw new NotImplementedException(); set => throw new NotImplementedException(); }
-        public string AzureStorage_Errors_ConnectionString { get => throw new NotImplementedException(); set => throw new NotImplementedException(); }
         public string AzureStorage_Packages_ConnectionString { get => throw new NotImplementedException(); set => throw new NotImplementedException(); }
         public string AzureStorage_FlatContainer_ConnectionString { get => throw new NotImplementedException(); set => throw new NotImplementedException(); }
         public string AzureStorage_Statistics_ConnectionString { get => throw new NotImplementedException(); set => throw new NotImplementedException(); }

src/NuGetGallery.Core/NuGetGallery.Core.csproj

@@ -65,9 +65,6 @@
     <PackageReference Include="NuGet.Services.Validation.Issues">
       <Version>$(ServerCommonPackageVersion)</Version>
     </PackageReference>
-    <PackageReference Include="NuGet.StrongName.elmah.corelibrary">
-      <Version>1.2.2</Version>
-    </PackageReference>
     <PackageReference Include="Microsoft.Data.Services.Client">
       <Version>5.8.4</Version>
     </PackageReference>

src/NuGetGallery.Services/Configuration/AppConfiguration.cs

@@ -48,9 +48,6 @@ public class AppConfiguration : IAppConfiguration
         [DisplayName("AzureStorage.Content.ConnectionString")]
         public string AzureStorage_Content_ConnectionString { get; set; }
 
-        [DisplayName("AzureStorage.Errors.ConnectionString")]
-        public string AzureStorage_Errors_ConnectionString { get; set; }
-
         [DisplayName("AzureStorage.Packages.ConnectionString")]
         public string AzureStorage_Packages_ConnectionString { get; set; }
 

src/NuGetGallery.Services/Configuration/IAppConfiguration.cs

@@ -55,11 +55,6 @@ public interface IAppConfiguration : IMessageServiceConfiguration
         /// </summary>
         string AzureStorage_Content_ConnectionString { get; set; }
 
-        /// <summary>
-        /// The Azure Storage connection string used for Elmah error logs.
-        /// </summary>
-        string AzureStorage_Errors_ConnectionString { get; set; }
-
         /// <summary>
         /// The Azure Storage connection string used for packages, after upload.
         /// </summary>