Remove elmah table usage from gallery #10021
Conversation
[ReleasePrep][2024.05.28]RI of dev into main
|
FYI @Lanaparezanin |
|
PR against |
| @@ -8,13 +8,10 @@ | |||
| namespace NuGetGallery.Diagnostics | |||
| { | |||
| [AttributeUsage(AttributeTargets.Class | AttributeTargets.Method, AllowMultiple = true)] | |||
| public sealed class SendErrorsToTelemetryAttribute | |||
| : ElmahHandleErrorAttribute | |||
| public sealed class SendErrorsToTelemetryAttribute : Attribute | |||
There was a problem hiding this comment.
Does this still get invoked without Elmah installed?
There was a problem hiding this comment.
Good catch--I'll remove this.
| @@ -295,7 +293,7 @@ private static void BackgroundJobsPostStart(IAppConfiguration configuration) | |||
| { | |||
| RestartSchedulerOnFailure = true | |||
| }; | |||
| _jobManager.Fail(e => ErrorLog.GetDefault(null).Log(new Error(e))); | |||
| _jobManager.Fail(e => { /* fail silently */ }); | |||
There was a problem hiding this comment.
It may be possible to use Trace here. I believe we have an App Insights trace listener. It might be worth having this "just in case".
|
Love the clean-up! |
drewgillies
dismissed stale reviews from joelverhagen and erdembayar
The base branch was changed.
|
Should it include a change to admin index page to remove Elmah link? |
drewgillies
force-pushed
the
dg-elmah
branch
2 times, most recently
from
0ad8b19 to
03182fe
Compare
|
I'm wondering why |
|
@erdembayar @joelverhagen the file being unsigned broke the build, and it persists in the build to support Elmah migrations (backward and, in future, forward [edit: correction--there was no backward migration to remove table/sprocs, and I doubt we'll add it--forward would be a good cleanup step though]). I will review this in separate work to see if it can be removed without removing migration support. See https://github.com/NuGet/Engineering/issues/5495 for tracking. |
Partially addresses: https://github.com/NuGet/Engineering/issues/5480
We'll remove this table's usage as a part of the SDK migration effort.