Fix: "Example glob patterns" button and "close" button are not access…

…ible using keyboard (#3968)
NuGet · May 16, 2017 · 6a7b75c · 6a7b75c
1 parent 74cd45a
commit 6a7b75c
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/NuGetGallery/Views/Users/ApiKeys.cshtml b/src/NuGetGallery/Views/Users/ApiKeys.cshtml
@@ -342,7 +342,7 @@
                              <a href="#" class="globHelpLink">Example glob patterns</a>.
                              <div class="popup">
                                  <div class="popupbox" id="addapikeypopup">
-                                     <a class="boxclose"><i class="icon-remove"></i></a>
+                                     <a href="#" class="boxclose"><i class="icon-remove"></i></a>
                                      <div class="innertext">
                                          A glob pattern allows you to replace any sequence of characters with '*'.
                                          <h5>Example glob patterns</h5>
@@ -599,11 +599,15 @@
         $('.boxclose')
                .click(function () {
                    $(this).parent().hide();
+                   // Prevent page jump
+                   return false;
                });
 
         $('.globHelpLink')
             .click(function () {
                 $(this).next().find('.popupbox').show();
+                // Prevent page jump
+                return false;
             });
     }
 </script>
@@ -1163,6 +1167,7 @@
         popupboxDiv.className = "popupbox editapikeypopup";
         var boxclose = document.createElement("a");
         boxclose.className = "boxclose";
+        boxclose.href = "#";
         var iconRemove = document.createElement("i");
         iconRemove.className = "icon-remove";
         boxclose.appendChild(iconRemove);