Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the version-less package page to show the latest stable, while giving users a good indication that there's a pre-release version available #403

Closed
half-ogre opened this issue Feb 6, 2012 · 7 comments
Assignees

Comments

@half-ogre
Copy link
Contributor

This is to avoid confusion for someone just coming to the landing page of a package expecting to get the latest. They should be shown the latest stable, not a pre-release package. At the same time, we want to make it easy for users to see and try out pre-release packages, so we want to make it that very easy to discover.

@markheath
Copy link

+1, I would like this feature.

@jeffhandley
Copy link
Member

+3 (@howarddierking, @RanjiniM, and me). Also, search results should always be versionless when we have this in place. For instance, presently, searching for "nuget.core" returns a "NuGet.Core 2.0.1" result instead of just "NuGet.Core."

@analogrelay
Copy link
Contributor

The client focuses on stable versions, so this seems good.

@analogrelay
Copy link
Contributor

Postponing to the site redesign.

@ghost ghost assigned TimLovellSmith Oct 3, 2013
@TimLovellSmith
Copy link
Member

Given that we said this is P1 why are we postponing it? I'm pulling this into this milestone.

@TimLovellSmith
Copy link
Member

How the fix will need to work:
We use the wonderful FindPackageByIdAndVersion method to find packages whenever someone doesn't specify a version. We actuallyuse that function from all these places where it seems logical to make the same change for consistency:

  1. API calls (e.g. nuget.exe) for:
    a) verify package key
    b) delete package [unlist]
    c) public package [relist]
    d) get package [download, including part of package install/restore etc.]
  2. PackagesController
    a) display package
    b) report abuse
    c) contact support
    d) edit package
    e) set license report visibility
    f) undo pending edits

The possibly most risky change to make is changing the API for get package. However I don't think it's risky in practice, because in practice nobody is calling the API without a version which they have looked up in the package feed.

[If they were, they might not have intended to get a prerelease package anyway, so yes this is probably a good change...]

@TimLovellSmith
Copy link
Member

It turns out that API call for get package already was passing a special parameter so that it would never let you get a prerelease version without specifying the version.

TimLovellSmith pushed a commit that referenced this issue Oct 3, 2013
Make the LATEST STABLE package version the one returned by default when version == null.
Make the LATEST version the one returned if no STABLE version exists and allowPrerelease == true.
joelverhagen added a commit that referenced this issue Jul 29, 2024
…403)

* Bump Microsoft.Owin from 4.1.0 to 4.1.1 in /src/NuGet.Services.Owin

Bumps [Microsoft.Owin](https://github.com/aspnet/AspNetKatana) from 4.1.0 to 4.1.1.
- [Release notes](https://github.com/aspnet/AspNetKatana/releases)
- [Commits](aspnet/AspNetKatana@v4.1.0...v4.1.1)

---
updated-dependencies:
- dependency-name: Microsoft.Owin
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* Remove explicit reference from tests

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Joel Verhagen <jver@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants