Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tilovell/403 latest stable should be default package version seen #1626

Merged

Conversation

TimLovellSmith
Copy link
Member

To fix #403 - 'change the version-less package page to show the latest stable, while giving users a good indication if there is a newer prerelease version available'.

Tim Lovell-Smith added 2 commits October 3, 2013 14:41
Make the LATEST STABLE package version the one returned by default when version == null.
Make the LATEST version the one returned if no STABLE version exists and allowPrerelease == true.
[Theory]
[InlineData(null)]
[InlineData("")]
public void WillThrowIfIdIsNull(string id)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<picking-nits-like-a-bawse>WillThrowIfIdIsNullOrEmpty</> :)

@analogrelay
Copy link
Contributor

:shipit:

analogrelay added a commit that referenced this pull request Oct 7, 2013
…DefaultPackageVersionSeen

Tilovell/403 latest stable should be default package version seen
@analogrelay analogrelay merged commit f43d1cd into dev Oct 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants