Migrate AccountDeleter job to MSI storage account access #10165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0976432.
drewgillies
changed the title
erdembayar
reviewed
Aug 29, 2024
| @@ -1,4 +1,4 @@ | |||
| // Copyright (c) .NET Foundation. All rights reserved. | |||
| // Copyright (c) .NET Foundation. All rights reserved. | |||
There was a problem hiding this comment.
Looks there's no actual change in this file. Should we revert the changes?
There was a problem hiding this comment.
This is a BOM removal, following the editorconfig. I think this change is fine.
erdembayar
approved these changes
Aug 29, 2024
joelverhagen
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: https://github.com/NuGet/Engineering/issues/5586
(Not seeing any reason for the
AccountDeleteConfigurationdelta here in the GitHub view of the diff). Due to complications in the base class DI implementation (see https://github.com/NuGet/Engineering/issues/5606), I've opted for the simple approach of implementing MSI auth via theUsingMsimethod.