Additional config changes to support AccountDeleter migration #10180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,4 +1,4 @@ | |||
| // Copyright (c) .NET Foundation. All rights reserved. | |||
| // Copyright (c) .NET Foundation. All rights reserved. | |||
There was a problem hiding this comment.
These files seem unnecessary but are harmless (probably editorconfig fixups).
joelverhagen
approved these changes
Sep 11, 2024
erdembayar
approved these changes
Sep 11, 2024
ryuyu
pushed a commit
that referenced
this pull request
Sep 20, 2024
Add bindingredirect for dependencyinjection.dll
ryuyu
added a commit
that referenced
this pull request
Sep 20, 2024
#10189) Add bindingredirect for dependencyinjection.dll Co-authored-by: Drew Gillies <drewgil@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: https://github.com/NuGet/Engineering/issues/5586 alongside #10165.
This completes the migration for
AccountDeleter--there was a null ref issue with configs inAccountDeleter'sJob's base classesValidationJobBase(which configures validation storage access) andJsonConfigurationJob(which configures feature flag storage access). Neither storage accounts are used byAccountDeleterand recent changes toCloudBlobClientWrapperhad removed a tolerance for nulls in the connection strings. An experimental change toCloudBlobWrapperClientsought to address this but wasn't successful, but left a BOM removal in code which is an acceptable push. FYI @agr.The
app.configchange is necessary for a break introduced in our deployment pipeline. I will discuss it in the context of an internal PR on this.